Skip to content

[9.0] [ML] Disable child span for streaming tasks (#132945) #133070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

[9.0] [ML] Disable child span for streaming tasks (#132945) #133070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/132945.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 132945
summary: Disable child span for streaming tasks
area: Machine Learning
type: bug
issues: []
2 changes: 1 addition & 1 deletion ...nce/src/main/java/org/elasticsearch/xpack/inference/action/task/StreamingTaskManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public Task createTask(long id, String type, String action, TaskId parentTaskId,
flowTask.addListener(TaskBackedProcessor.this::cancelTask);
return flowTask;
}
});
}, false);
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions ...rc/test/java/org/elasticsearch/xpack/inference/action/task/StreamingTaskManagerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public void setUp() throws Exception {
doAnswer(ans -> {
TaskAwareRequest taskAwareRequest = ans.getArgument(2);
return taskAwareRequest.createTask(1L, taskType, taskAction, TaskId.EMPTY_TASK_ID, Map.of());
}).when(taskManager).register(any(), any(), any());
}).when(taskManager).register(any(), any(), any(), eq(false));
}

@After
Expand All @@ -67,7 +67,7 @@ public void testSubscribeRegistersTask() {

processor.subscribe(mock());

verify(taskManager, only()).register(eq(taskType), eq(taskAction), any());
verify(taskManager, only()).register(eq(taskType), eq(taskAction), any(), eq(false));
}

public void testCancelPropagatesUpstreamAndDownstream() {
Expand All @@ -77,7 +77,7 @@ public void testCancelPropagatesUpstreamAndDownstream() {
var registeredTask = (CancellableTask) taskAwareRequest.createTask(1L, taskType, taskAction, TaskId.EMPTY_TASK_ID, Map.of());
task.set(registeredTask);
return registeredTask;
}).when(taskManager).register(any(), any(), any());
}).when(taskManager).register(any(), any(), any(), eq(false));

Flow.Subscriber<Object> downstream = mock();
Flow.Subscription upstream = mock();
Expand Down Expand Up @@ -173,7 +173,7 @@ public void testOnNextAfterCancelDoesNotForwardItem() {
var registeredTask = (CancellableTask) taskAwareRequest.createTask(1L, taskType, taskAction, TaskId.EMPTY_TASK_ID, Map.of());
task.set(registeredTask);
return registeredTask;
}).when(taskManager).register(any(), any(), any());
}).when(taskManager).register(any(), any(), any(), eq(false));

var processor = streamingTaskManager.create(taskType, taskAction);
var downstream = establishFlow(processor);
Expand Down