Skip to content

Conversation

@picandocodigo
Copy link
Member

@picandocodigo picandocodigo added the :Core/Infra/REST API REST infrastructure and utilities label Aug 19, 2025
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v9.2.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 19, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@ldematte
Copy link
Contributor

Hello @picandocodigo, I'm not sure what's the intent of this PR.
Changing the spec will not change the implementation of the REST action (which after a quick search I think is https://github.com/elastic/elasticsearch/blob/main/modules/rest-root/src/main/java/org/elasticsearch/rest/root/RestMainAction.java#L33), so this actually will not fix the linked issue.
In order to review and give you pointers, we'd need to know how do you plan to proceed. Do you plan to submit multiple PRs maybe?

@ldematte
Copy link
Contributor

Also, please avoid to force push changes: we usually don't do that, as it makes reviews more difficult and changes hard to trace (losing history)

@ldematte
Copy link
Contributor

A final note: changing the method is a breaking change, so probably it's worth discussing implications and options before proceeding (e.g. on the linked issue, pinging us on our slack channel, or joining us at our weekly sync if this is urgent).

@ldematte ldematte self-assigned this Aug 20, 2025
@picandocodigo
Copy link
Member Author

Hi @ldematte, thanks for looking into this. Initially I thought this change would involve much less and be simpler. After discussing this more with the team, we agreed we won't go ahead with changing the method and keep using HEAD. The force push changes were from rebasing to the latest main, but I'll have this in mind for future Pull Requests. Thanks!

@ldematte
Copy link
Contributor

No prob!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/REST API REST infrastructure and utilities external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Core/Infra Meta label for core/infra team v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ship with monitor_ping built in privilege

3 participants