Skip to content

Unmute v_magnitude analyzer tests #133139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svilen-mihaylov-elastic merged 2 commits into from
Aug 19, 2025
Merged

Unmute v_magnitude analyzer tests #133139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4566307
Unmute tests
svilen-mihaylov-elastic Aug 19, 2025
46346ed
Merge branch 'main' into svilen/132985_and_133013
svilen-mihaylov-elastic Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,9 +543,6 @@ tests:
- class: org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT
method: test {p0=search/160_exists_query/Test exists query on unmapped float field}
issue: https://github.com/elastic/elasticsearch/issues/132984
- class: org.elasticsearch.xpack.esql.analysis.AnalyzerTests
method: testMagnitudePlanWithDenseVectorImplicitCasting
issue: https://github.com/elastic/elasticsearch/issues/132985
- class: org.elasticsearch.xpack.search.AsyncSearchErrorTraceIT
method: testAsyncSearchFailingQueryErrorTraceDefault
issue: https://github.com/elastic/elasticsearch/issues/133010
Expand Down Expand Up @@ -582,9 +579,6 @@ tests:
- class: org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT
method: test {p0=search/160_exists_query/Test exists query on _id field}
issue: https://github.com/elastic/elasticsearch/issues/133097
- class: org.elasticsearch.xpack.esql.analysis.AnalyzerTests
method: testNoDenseVectorFailsForMagnitude
issue: https://github.com/elastic/elasticsearch/issues/133013
- class: org.elasticsearch.xpack.ml.integration.TextEmbeddingQueryIT
method: testModelWithPrefixStrings
issue: https://github.com/elastic/elasticsearch/issues/133138
Expand Down
4 changes: 4 additions & 0 deletions x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2444,6 +2444,8 @@ private void checkNoDenseVectorFailsSimilarityFunction(String similarityFunction
}

public void testMagnitudePlanWithDenseVectorImplicitCasting() {
assumeTrue("v_magnitude not available", EsqlCapabilities.Cap.MAGNITUDE_SCALAR_VECTOR_FUNCTION.isEnabled());

var plan = analyze(String.format(Locale.ROOT, """
from test | eval scalar = v_magnitude([1, 2, 3])
"""), "mapping-dense_vector.json");
Expand All @@ -2459,6 +2461,8 @@ public void testMagnitudePlanWithDenseVectorImplicitCasting() {
}

public void testNoDenseVectorFailsForMagnitude() {
assumeTrue("v_magnitude not available", EsqlCapabilities.Cap.MAGNITUDE_SCALAR_VECTOR_FUNCTION.isEnabled());

var query = String.format(Locale.ROOT, "row a = 1 | eval scalar = v_magnitude(0.342)");
VerificationException error = expectThrows(VerificationException.class, () -> analyze(query));
assertThat(
Expand Down