Skip to content

Fix GlobTests flaky test with asterisks in string #133140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix GlobTests flaky test with asterisks in string #133140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7455e96
Fix GlobTests flaky test with asterisks in string
ivancea Aug 19, 2025
2face21
Merge branch 'main' into fix-flaky-glob-test
tvernum Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/core/src/test/java/org/elasticsearch/core/GlobTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ interface CharPredicate {
}

private String randomAsciiString(int length) {
return randomAsciiString(length, ch -> ch >= ' ' && ch <= '~');
return randomAsciiString(length, ch -> ch >= ' ' && ch <= '~' && ch != '*');
Copy link
Contributor

@ldematte ldematte Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is identical to the randomAsciiStringNoAsterisks introduced in #133114, I think this has already been addressed?

Copy link
Contributor Author

@ivancea ivancea Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks for noticing! I'm closing this one

}

private String randomAsciiStringNoAsterisks(final int length) {
Expand Down