Skip to content

Remove batched override in TermsDocCountErrorIT #133159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benchaplin wants to merge 2 commits into from
Closed

Remove batched override in TermsDocCountErrorIT #133159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86e499b
Remove batched override and add repeat iterations for CI
benchaplin Aug 19, 2025
940acfd
[CI] Auto commit changes from spotless
Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions ...alClusterTest/java/org/elasticsearch/search/aggregations/bucket/TermsDocCountErrorIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,19 @@

package org.elasticsearch.search.aggregations.bucket;

import com.carrotsearch.randomizedtesting.annotations.Repeat;

import org.elasticsearch.action.index.IndexRequestBuilder;
import org.elasticsearch.action.search.SearchResponse;
import org.elasticsearch.cluster.metadata.IndexMetadata;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.search.SearchService;
import org.elasticsearch.core.SuppressForbidden;
import org.elasticsearch.search.aggregations.Aggregator.SubAggCollectionMode;
import org.elasticsearch.search.aggregations.BucketOrder;
import org.elasticsearch.search.aggregations.bucket.terms.Terms;
import org.elasticsearch.search.aggregations.bucket.terms.Terms.Bucket;
import org.elasticsearch.search.aggregations.bucket.terms.TermsAggregatorFactory.ExecutionMode;
import org.elasticsearch.test.ESIntegTestCase;
import org.junit.After;
import org.junit.Before;

import java.io.IOException;
import java.util.ArrayList;
Expand All @@ -41,6 +41,8 @@
import static org.hamcrest.core.IsNull.notNullValue;

@ESIntegTestCase.SuiteScopeTestCase
@SuppressForbidden(reason = "testing")
@Repeat(iterations = 100)
public class TermsDocCountErrorIT extends ESIntegTestCase {

private static final String STRING_FIELD_NAME = "s_value";
Expand All @@ -53,17 +55,17 @@ public static String randomExecutionHint() {

private static int numRoutingValues;

@Before
public void disableBatchedExecution() {
// TODO: it's practically impossible to get a 100% deterministic test with batched execution unfortunately, adjust this test to
// still do something useful with batched execution (i.e. use somewhat relaxed assertions)
updateClusterSettings(Settings.builder().put(SearchService.BATCHED_QUERY_PHASE.getKey(), false));
}

@After
public void resetSettings() {
updateClusterSettings(Settings.builder().putNull(SearchService.BATCHED_QUERY_PHASE.getKey()));
}
// @Before
// public void disableBatchedExecution() {
// // TODO: it's practically impossible to get a 100% deterministic test with batched execution unfortunately, adjust this test to
// // still do something useful with batched execution (i.e. use somewhat relaxed assertions)
// updateClusterSettings(Settings.builder().put(SearchService.BATCHED_QUERY_PHASE.getKey(), false));
// }
//
// @After
// public void resetSettings() {
// updateClusterSettings(Settings.builder().putNull(SearchService.BATCHED_QUERY_PHASE.getKey()));
// }

@Override
public void setupSuiteScopeCluster() throws Exception {
Expand Down