Randomized TSDS tests: rate test and fixes to gauge tests #133190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrik-es
reviewed
Aug 20, 2025
...src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/RandomizedTimeSeriesIT.java
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Aug 20, 2025
...src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/RandomizedTimeSeriesIT.java
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Aug 20, 2025
...src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/TSDataGenerationHelper.java
Outdated
Show resolved
Hide resolved
pabloem
force-pushed
the
pem-rate-rnd-tst
branch
from
56b3a32 to
45ae0e8
Compare
kkrik-es
reviewed
Aug 29, 2025
...src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/RandomizedTimeSeriesIT.java
Outdated
Show resolved
Hide resolved
kkrik-es
approved these changes
Aug 29, 2025
kkrik-es
added
>test
|
Let's also add a description, always. |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two test cases to validate calculation and aggregations of counter-type metrics using RATE functions.
For now, the window size and aggregations are fixed, but the data is fully random.
RATE calculations are verified with an upper and lower bound (these can actually be quite different, but it's necessary to account for different extrapolation logical paths when calculating rates.