Use path separator for git path in transport resources #133228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking up files from main in transport resources, the system dependent path is used. However, the beginning slash also needs to be system dependent.
elasticsearchmachine
added
needs:triage
rjernst
added
:Analytics/Geo
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
rjernst
removed
:Analytics/Geo
elasticsearchmachine
added
the
needs:triage
JVerwolf
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
JVerwolf
approved these changes
Aug 20, 2025
rjernst
added
>non-issue
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 20, 2025
When looking up files from main in transport resources, the system dependent path is used. However, the beginning slash also needs to be system dependent.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 20, 2025
* Replace transport version utils with a build service (#133034) Several transport version build tasks have a need to access the repository-wide transport version resources. Thus far it has been done through several utility methods. This commit moves these utility methods into an encapsulated build service that is shared across the transport version tasks. The advantage is that no paths are used, the build service encapsulates access to the resources and understands internally how to find the correct filesystem path and load it. * Make transport version ids have descending ordering (#133185) Transport version ids must be in descending order in definition files. However, the compareTo for them was ascending and the validation used reverse ordering. This commit fixes the compareTo so it uses desending ordering and the validation uses natural ordering. * Fix transport version validation task name (#133186) The task class validates resources, but the task name still had the old "definitions" suffix. * Add separate validation for unreferenced transport version definitions (#133189) This commit splits out the validation that is pertinent to unreferenced definitions. It also adds validation that names of named and unreferenced definitions cannot collide. * Use path separator for git path in transport resources (#133228) When looking up files from main in transport resources, the system dependent path is used. However, the beginning slash also needs to be system dependent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking up files from main in transport resources, the system dependent path is used. However, the beginning slash also needs to be system dependent.