Skip to content

[9.1] Change GeoIpCache and EnrichCache to LongAdder (#132922) #133250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

[9.1] Change GeoIpCache and EnrichCache to LongAdder (#132922) #133250

merged 1 commit into from
Aug 20, 2025

Conversation

@szybia
Copy link
Contributor

@szybia szybia commented Aug 20, 2025

Backports the following commits to 9.1:

@szybia
Change GeoIpCache and EnrichCache to LongAdder (elastic#132922)
728f91a 
From the javadocs:

> [`LongAdder`] is usually preferable to `AtomicLong` when multiple threads update a common sum that is used for purposes such as collecting statistics, not for fine-grained synchronization control.

Since we largely write stats and read very infrequently, let's avoid any lock-contention possibilities by switching to the more appropriate data type.
@szybia szybia added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Data Management Meta label for data/management team labels Aug 20, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Aug 20, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit 4636f4d into elastic:9.1 Aug 20, 2025
34 checks passed
@szybia szybia deleted the backport/9.1/pr-132922 branch August 20, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team v9.1.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@szybia @elasticsearchmachine