Skip to content

Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic #133261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smalyshev merged 5 commits into from
Aug 21, 2025
Merged

Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic #133261

smalyshev merged 5 commits into from
Aug 21, 2025

Conversation

@smalyshev
Copy link
Contributor

@smalyshev smalyshev commented Aug 20, 2025

In this test, the full result set for this query:

 FROM my_remote_cluster:employees
            | ENRICH countries
            | STATS size=count(*) by country
            | SORT size DESC
            | LIMIT 2

is before limit:

[[3, usa], [1, japan], [1, germany]]

Cutting it down to 2 is therefore non-deterministic. This pull extends limit to 3 and makes the result deterministic.

Closes #133031

@smalyshev smalyshev added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v9.2.0 v9.1.4 v8.19.3 v8.18.6 auto-backport Automatically create backport pull requests when merged labels Aug 20, 2025
@smalyshev smalyshev marked this pull request as ready for review August 20, 2025 20:14
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 20, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Aug 20, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

@smalyshev smalyshev requested a review from jakelandis August 20, 2025 20:15
dnhatn
dnhatn approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@smalyshev smalyshev enabled auto-merge (squash) August 20, 2025 21:40
@smalyshev smalyshev merged commit 20bd151 into elastic:main Aug 21, 2025
34 checks passed
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Aug 21, 2025

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 8.19 Commit could not be cherrypicked due to conflicts
❌ 9.1 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 133261

@smalyshev smalyshev mentioned this pull request Aug 21, 2025
Merged
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Aug 21, 2025
@smalyshev
Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic (elastic…
436db50 
…#133261)

(cherry picked from commit 20bd151)

# Conflicts:
#	muted-tests.yml
This was referenced Aug 21, 2025
Merged
Merged
Merged
@smalyshev
Copy link
Contributor Author

smalyshev commented Aug 21, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1
✅ 9.0
✅ 8.19
✅ 8.18

Questions ?

Please refer to the Backport tool documentation

smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Aug 21, 2025
@smalyshev
Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic (elastic…
b91292b 
…#133261)

(cherry picked from commit 20bd151)

# Conflicts:
#	muted-tests.yml
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Aug 21, 2025
@smalyshev
Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic (elastic…
de0b898 
…#133261)

(cherry picked from commit 20bd151)

# Conflicts:
#	muted-tests.yml
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Aug 21, 2025
@smalyshev
Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic (elastic…
8838d4b 
…#133261)

(cherry picked from commit 20bd151)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Aug 21, 2025
@smalyshev
Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic (#133261) (
fae71e4 
#133279)

(cherry picked from commit 20bd151)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Aug 21, 2025
@smalyshev
Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic (#133261) (
cbec48f 
#133278)

(cherry picked from commit 20bd151)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Aug 21, 2025
@smalyshev
Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic (#133261) (
97571a2 
#133281)

(cherry picked from commit 20bd151)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Aug 21, 2025
@smalyshev
[8.19] Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic (#…
16abdce 
…133261) (#133280)

* Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic (#133261)

(cherry picked from commit 20bd151)

# Conflicts:
#	muted-tests.yml

* fix muted tests
ivancea pushed a commit to ivancea/elasticsearch that referenced this pull request Aug 26, 2025
@smalyshev @ivancea
Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic (elastic…
1368cd1 
…#133261)
@ivancea ivancea mentioned this pull request Aug 26, 2025
Merged
ivancea added a commit that referenced this pull request Aug 26, 2025
@ivancea
[8.17] Make testCrossClusterEnrichWithOnlyRemotePrivs deterministic (#…
ebc7f0c 
…133261) (#133532)

Manual 8.17 backport of #133261

Fixes #133428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnhatn dnhatn dnhatn approved these changes

@jakelandis jakelandis Awaiting requested review from jakelandis

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.6 v8.19.3 v9.0.7 v9.1.4 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] RemoteClusterSecurityEsqlIT testCrossClusterEnrichWithOnlyRemotePrivs failing

3 participants

@smalyshev @elasticsearchmachine @dnhatn