Allow dynamic defaults in mappings of managed system indices #133262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
added
>enhancement
:Data Management/Indices APIs
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @jimczi, I've created a changelog YAML for you. |
dakrone
added
:Core/Infra/Core
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
System indices with non-dynamic mappings normally reject `put mapping` requests that attempt to modify the mapping of a managed index. However, for fields like `dense_vector` and `semantic_text`, some mapping options depend on the shape of the ingested data. The first ingestion often requires a dynamic update to set these defaults. To support this for system indices, this change marks the relevant `put mapping` requests as originating from bulk ingestion, which bypasses the system index mapping check. This is safe because: * such updates are already validated against invalid dynamic updates, and * an error would be raised earlier if a new field is added when `dynamic` is disabled. Fixes elastic#133171 naming
jimczi
force-pushed
the
system_index_dynamic_default
branch
from
fa20dc3 to
9705810
Compare
|
A couple of questions to clarify:
|
It is, see below.
Yes, see It is called as part of the bulk action if a dynamic update is needed. For the check, see The idea is that put mapping requests are not checked for system index violations if they are generated by the system indirectly. |
alexey-ivanov-es
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System indices with non-dynamic mappings normally reject
put mappingrequests that attempt to modify the mapping of a managed index.However, for fields like
dense_vectorandsemantic_text, some mapping options depend on the shape of the ingested data. The first ingestion often requires a dynamic update to set these defaults.To support this for system indices, this change marks the relevant
put mappingrequests as originating from bulk ingestion, which bypasses the system index mapping check. This is safe because:dynamicis disabled.Fixes #133171