Make AsyncWaitStep#evaluateCondition take an IndexMetadata instead of Index
#133292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of `Index` This avoids subclasses from having to look up the index metadata themselves, which in turn saves some null-checks.
nielsbauman
added
>refactoring
:Data Management/ILM+SLM
elasticsearchmachine
added
v9.2.0
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the AsyncWaitStep#evaluateCondition method to accept an IndexMetadata parameter instead of an Index parameter. This change eliminates the need for subclasses to perform index metadata lookups and associated null-checks, simplifying the implementation.
Key changes:
- Modified the abstract method signature in
AsyncWaitStepto takeIndexMetadatainstead ofIndex - Updated all concrete implementations to use the provided
IndexMetadatadirectly - Updated test files to pass
IndexMetadataobjects to the method calls
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| AsyncWaitStep.java | Changed abstract method signature to accept IndexMetadata parameter |
| IndexLifecycleRunner.java | Updated method call to pass IndexMetadata instead of Index |
| WaitUntilTimeSeriesEndTimePassesStep.java | Removed index metadata lookup and null-check, uses provided parameter |
| WaitUntilReplicateForTimePassesStep.java | Removed index metadata lookup and null-check, uses provided parameter |
| WaitForSnapshotStep.java | Removed index metadata lookup and null-check, uses provided parameter |
| WaitForRolloverReadyStep.java | Updated to use provided IndexMetadata parameter directly |
| WaitForNoFollowersStep.java | Simplified to use IndexMetadata parameter and extract index name |
| WaitForFollowShardTasksStep.java | Removed index metadata lookup, uses provided parameter |
| SegmentCountStep.java | Updated to use IndexMetadata parameter and extract Index when needed |
| Multiple test files | Updated test method calls to pass IndexMetadata objects |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 21, 2025
… instead of `Index` (#133292) (#133300) * Make `AsyncWaitStep#evaluateCondition` take an `IndexMetadata` instead of `Index` (#133292) This avoids subclasses from having to look up the index metadata themselves, which in turn saves some null-checks. (cherry picked from commit b0c4ca4) # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/AsyncWaitStep.java # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/SegmentCountStep.java # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitForFollowShardTasksStep.java # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitForNoFollowersStep.java # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitForRolloverReadyStep.java # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitForSnapshotStep.java # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitUntilReplicateForTimePassesStep.java # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitUntilTimeSeriesEndTimePassesStep.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/SegmentCountStepTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/WaitForFollowShardTasksStepTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/WaitForNoFollowersStepTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/WaitForRolloverReadyStepTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/WaitForSnapshotStepTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/WaitUntilReplicateForTimePassesStepTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/WaitUntilTimeSeriesEndTimePassesStepTests.java # x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/IndexLifecycleRunner.java # x-pack/plugin/ilm/src/test/java/org/elasticsearch/xpack/ilm/IndexLifecycleRunnerTests.java * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids subclasses from having to look up the index metadata themselves, which in turn saves some null-checks.