ESQL: Fix wrong marking of a field as unmapped when indices shared the same mapping #133298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalLalouche
added
>bug
Team:Analytics
GalLalouche
force-pushed
the
gall_bug/fix_insist_same_mapping_20250821
branch
from
407cd8b to
1e6f531
Compare
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
|
||
| var isPartiallyUnmapped = fcs.size() < numberOfIndices; | ||
| if (isPartiallyUnmapped) { | ||
| if (fieldCapsResponse.getIndexResponses().stream().allMatch(fcir -> fcir.get().containsKey(fullName)) == false) { |
There was a problem hiding this comment.
I suspect this could be a bit expensive for many fields or many indices or both cases.
Lets check if this affects esql/from_idx_limit_1 benchmark after merging.
There was a problem hiding this comment.
I've fixed the potential issue by instead of also taking into account the number of mapping hash duplicates.
idegtiarenko
approved these changes
Aug 21, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Aug 28, 2025
…e same mapping (elastic#133298) A follow up fixing https://github.com/elastic/elasticsearch/pull/119886/files/e32a4463e8a4015c7be17cb984a80e79ed1e45c5#r2287545802. The original issue, as mentioned in the comment, was triggered by multiple indices sharing the same mapping. This PR fixes it by reading the FieldCapabilitiesResponse directly instead.
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Aug 28, 2025
…e same mapping (elastic#133298) A follow up fixing https://github.com/elastic/elasticsearch/pull/119886/files/e32a4463e8a4015c7be17cb984a80e79ed1e45c5#r2287545802. The original issue, as mentioned in the comment, was triggered by multiple indices sharing the same mapping. This PR fixes it by reading the FieldCapabilitiesResponse directly instead.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 28, 2025
…e same mapping (#133298) (#133698) A follow up fixing https://github.com/elastic/elasticsearch/pull/119886/files/e32a4463e8a4015c7be17cb984a80e79ed1e45c5#r2287545802. The original issue, as mentioned in the comment, was triggered by multiple indices sharing the same mapping. This PR fixes it by reading the FieldCapabilitiesResponse directly instead.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 28, 2025
…e same mapping (#133298) (#133699) A follow up fixing https://github.com/elastic/elasticsearch/pull/119886/files/e32a4463e8a4015c7be17cb984a80e79ed1e45c5#r2287545802. The original issue, as mentioned in the comment, was triggered by multiple indices sharing the same mapping. This PR fixes it by reading the FieldCapabilitiesResponse directly instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up fixing https://github.com/elastic/elasticsearch/pull/119886/files/e32a4463e8a4015c7be17cb984a80e79ed1e45c5#r2287545802.
The original issue, as mentioned in the comment, was triggered by multiple indices sharing the same mapping. This PR fixes it by reading the
FieldCapabilitiesResponsedirectly instead.