-
Notifications
You must be signed in to change notification settings - Fork 25.5k
DATE_RANGE data type for esql #133309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
DATE_RANGE data type for esql #133309
Conversation
bf3e582
to
572349d
Compare
server/src/main/java/org/elasticsearch/index/mapper/RangeFieldMapper.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/index/mapper/TestBlock.java
Show resolved
Hide resolved
.../plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/DateRangeBlockBuilder.java
Outdated
Show resolved
Hide resolved
ff774e6
to
2f8e144
Compare
2f8e144
to
870d453
Compare
x-pack/plugin/esql/qa/testFixtures/src/main/java/org/elasticsearch/xpack/esql/CsvAssert.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/RangeFieldMapper.java
Outdated
Show resolved
Hide resolved
I'd add another test to After than, I'd try and get the rest of the tests passing. |
a851d6b
to
cba120d
Compare
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
cba120d
to
64a8dcb
Compare
9930775
to
0591d5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. I think it's time to drop draft from this, get all the tests happy, and get it in. Then we can extend it with stuff like supporting this field type in top n (not as a sort key, but as a sorted field), COALESCE, TO_STRING, etc. And maybe a TO_DATE_RANGE
function too. Lots of separate stuff we can build on top of this.
server/src/main/java/org/elasticsearch/index/mapper/RangeFieldMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/RangeFieldMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/RangeFieldMapper.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/BlockFactory.java
Outdated
Show resolved
Hide resolved
5ea25dc
to
ec5bd46
Compare
cc61080
to
2dd3f6a
Compare
2dd3f6a
to
5a20af6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Let's get this un-drafted. I'm pretty comfortable getting this in if CI is happy.
Once CI is truly happy I'll give it one more look, hopefully just to find follow up stuff.
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/enrich/EnrichPolicyResolver.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/DateRangeBlock.java
Show resolved
Hide resolved
5a20af6
to
6666c35
Compare
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Hi @shmuelhanoch, I've created a changelog YAML for you. |
ca78270
to
3491087
Compare
fbd19a9
to
c901ae6
Compare
c901ae6
to
d9003d4
Compare
Basic support for DATE_RANGE field type.