Skip to content

Conversation

shmuelhanoch
Copy link
Contributor

@shmuelhanoch shmuelhanoch commented Aug 21, 2025

Basic support for DATE_RANGE field type.

@shmuelhanoch shmuelhanoch force-pushed the esql_date_range_data_type branch 4 times, most recently from bf3e582 to 572349d Compare September 10, 2025 16:38
@shmuelhanoch shmuelhanoch force-pushed the esql_date_range_data_type branch 3 times, most recently from ff774e6 to 2f8e144 Compare September 16, 2025 15:12
@shmuelhanoch shmuelhanoch force-pushed the esql_date_range_data_type branch from 2f8e144 to 870d453 Compare September 16, 2025 15:23
@nik9000
Copy link
Member

nik9000 commented Sep 16, 2025

I'd add another test to x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/esql/10_basic.yml that loads the range and asserts that output looks right. That should work given when you are, but it's really simple to point at.

After than, I'd try and get the rest of the tests passing.

Copy link
Contributor

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@shmuelhanoch shmuelhanoch force-pushed the esql_date_range_data_type branch from cba120d to 64a8dcb Compare September 21, 2025 19:24
@shmuelhanoch shmuelhanoch force-pushed the esql_date_range_data_type branch 2 times, most recently from 9930775 to 0591d5b Compare September 22, 2025 14:54
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I think it's time to drop draft from this, get all the tests happy, and get it in. Then we can extend it with stuff like supporting this field type in top n (not as a sort key, but as a sorted field), COALESCE, TO_STRING, etc. And maybe a TO_DATE_RANGE function too. Lots of separate stuff we can build on top of this.

@shmuelhanoch shmuelhanoch force-pushed the esql_date_range_data_type branch 5 times, most recently from 5ea25dc to ec5bd46 Compare September 26, 2025 18:37
@shmuelhanoch shmuelhanoch force-pushed the esql_date_range_data_type branch 4 times, most recently from cc61080 to 2dd3f6a Compare October 8, 2025 09:55
@shmuelhanoch shmuelhanoch requested a review from nik9000 October 8, 2025 10:23
@shmuelhanoch shmuelhanoch force-pushed the esql_date_range_data_type branch from 2dd3f6a to 5a20af6 Compare October 8, 2025 12:35
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's get this un-drafted. I'm pretty comfortable getting this in if CI is happy.

Once CI is truly happy I'll give it one more look, hopefully just to find follow up stuff.

@shmuelhanoch shmuelhanoch marked this pull request as ready for review October 8, 2025 23:15
@shmuelhanoch shmuelhanoch force-pushed the esql_date_range_data_type branch from 5a20af6 to 6666c35 Compare October 8, 2025 23:15
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Oct 8, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Oct 8, 2025
@shmuelhanoch shmuelhanoch added the >new-field-mapper Added when a new field type / mapper is being introduced label Oct 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @shmuelhanoch, I've created a changelog YAML for you.

@shmuelhanoch shmuelhanoch force-pushed the esql_date_range_data_type branch 2 times, most recently from ca78270 to 3491087 Compare October 8, 2025 23:52
@shmuelhanoch shmuelhanoch requested a review from nik9000 October 9, 2025 00:13
@shmuelhanoch shmuelhanoch force-pushed the esql_date_range_data_type branch 3 times, most recently from fbd19a9 to c901ae6 Compare October 9, 2025 22:44
@shmuelhanoch shmuelhanoch force-pushed the esql_date_range_data_type branch from c901ae6 to d9003d4 Compare October 10, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >new-field-mapper Added when a new field type / mapper is being introduced Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants