ES|QL: Unmute tests for GenerativeForkIT #133316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanatia
added
>test
ioanatia
commented
Aug 21, 2025
| issue: https://github.com/elastic/elasticsearch/issues/132733 | ||
| - class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeForkIT | ||
| method: test {csv-spec:lookup-join.MvJoinKeyFromRowExpanded} | ||
| issue: https://github.com/elastic/elasticsearch/issues/132778 |
Contributor
Author
There was a problem hiding this comment.
this was already fixed and closed - we just did not unmute the test
elasticsearchmachine
added
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
kderusso
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #129228
closes #129210
After we improved the field resolution in #131723, it should be safe to unmute these tests.
The initial failures had to do with the queries returning warning headers that were not accounted for in the test.
Initially a query using FORK would request all fields, so we would generate warnings like this one when date nanos fields were loaded:
The field resolution for FORK was improved, we are trying to request only the fields that are used in the query.
Therefore we will no longer load the date nanos fields that were causing these warnings and we can unmute the tests.