refactor(semantic_text)!: fail early on unsupported sparse_vector indices #133324
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sparse_v index versions
elasticsearchmachine
added
needs:triage
mromaios
added
:SearchOrg/Relevance
elasticsearchmachine
added
Team:SearchOrg
Collaborator
|
Pinging @elastic/search-eng (Team:SearchOrg) |
elasticsearchmachine
removed
the
needs:triage
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
mromaios
changed the title
Contributor
Author
|
Thanks for the review and the discussion @kderusso. After further discussing this, we will proceed with another approach. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin-off from: #133080
See: #133080 (comment) for details.
In this PR we move failing creating a
semantic_textfield with asparse_vectormodel on old indices earlier, on mapping creation time instead of document parsing.