tests for rate function in csv #133345
Merged
tests for rate function in csv #133345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
pabloem
changed the title
9 tasks
kkrik-es
reviewed
Aug 22, 2025
x-pack/plugin/esql/qa/testFixtures/src/main/resources/k8s-timeseries-rate.csv-spec
Outdated
Show resolved
Hide resolved
kkrik-es
approved these changes
Aug 22, 2025
Contributor
kkrik-es
left a comment
kkrik-es
left a comment
There was a problem hiding this comment.
Nice, consider adding more elaborate cases in a follow-up:
- Null values
- Nested expression
rate(foo + 10) - Combined functions like
avg(rate(foo) / rate(bar)),sum(rate(foo)) / sum(rate(bar))
Contributor
pabloem
force-pushed
the
pem-csv-rate-tests
branch
from
10ae3e1 to
3b0305d
Compare
Contributor
Author
|
docs test passing: https://buildkite.com/elastic/docs-build-pr/builds/409663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.