Add tracing support to ES Security #133363
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tracing support for the
authenticateaction by wrapping theauthenticator.authenticatecall inAuthenticatorChainwithstartTrace/stopTraceactions.In synchronous contexts, spans are stored in
ThreadLocalobjects under the hood and the currently active span look up (needed to end a span, append metadata, or spawn a child span) can be implicit. However, to track a span across threads asActionListenerpattern requires, we need to makeAuthenticator.ContextimplementTraceablewhich defines a random, uniquespanIdfor eachAuthenticator.Contextobject, enabling us to uniquely locate the associated span regardless of which thread is currently executing.Sample trace when running locally with
./gradlew :run --with-apm-server: