fix flaky testInvalidToken #133380
Merged
fix flaky testInvalidToken #133380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-dennehy
added
>test
|
Pinging @elastic/es-security (Team:Security) |
richard-dennehy
added
auto-backport
💚 Backport successful
|
richard-dennehy
added a commit
to richard-dennehy/elasticsearch
that referenced
this pull request
Aug 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133328
The primary issue is that in this particular code path,
SecurityIndexManager.IndexState.checkIndexVersionThenExecutegets invoked but isn't stubbed; this results in the provided callback never getting invoked, and the test hangs waiting for it to run.It looks like the issue was introduced here; that commit replaces the default mock
SecurityIndexManager.IndexState- which provides an implementation ofcheckIndexVersionThenExecute- with another mock which doesn't