Extend docs on double-completion using SubscribableListener
#133391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SubscribableListener` test suite asserts that the listener passed to the callbacks provided to `newForked` and `andThen` is identical to the returned listener, and therefore a `SubscribableListener`, so it is acceptable to complete these things racily. This commit adds a note to the relevant JavaDocs clarifying this point.
DaveCTurner
added
>docs
elasticsearchmachine
added
Team:Docs
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Collaborator
|
Pinging @elastic/core-docs (Team:Docs) |
DaveCTurner
deleted the
2025/08/22/SubscribableListener-deduplicating-actions
branch
pabloem
pushed a commit
to pabloem/elasticsearch
that referenced
this pull request
Aug 22, 2025
…c#133391) The `SubscribableListener` test suite asserts that the listener passed to the callbacks provided to `newForked` and `andThen` is identical to the returned listener, and therefore a `SubscribableListener`, so it is acceptable to complete these things racily. This commit adds a note to the relevant JavaDocs clarifying this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SubscribableListenertest suite asserts that the listener passedto the callbacks provided to
newForkedandandThenis identical tothe returned listener, and therefore a
SubscribableListener, so it isacceptable to complete these things racily. This commit adds a note to
the relevant JavaDocs clarifying this point.