fixing flakiness in RandomizedTimeSeriesIT - generating unique timestamps #133489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.2.0
needs:triage
pabloem
added
>bug
:StorageEngine/TSDB
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Aug 26, 2025
| indexRequest.get(); | ||
| documents.add(document); | ||
| } catch (Exception e) { | ||
| // Ignore version conflicts, which can happen due to retries on the client side |
There was a problem hiding this comment.
What does this mean? I think version conflicts point to documents with the same tsid and timestamp.
Can we make sure we generate unique timestamps instead?
There was a problem hiding this comment.
implemented that. lmk what you think.
Why not using randomInstantBetween?
Because that function uses nanosecond precision but ES stores millisecond precision, so we can have collisions that are not captured by the set.
|
Let's make sure the description always explains the underlying problem and the fix - no need to make it too long. |
kkrik-es
added
>test
pabloem
changed the title
|
@kkrik-es done! LMK if my fix is fine. |
kkrik-es
reviewed
Aug 28, 2025
...src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/TSDataGenerationHelper.java
Show resolved
Hide resolved
kkrik-es
approved these changes
Aug 28, 2025
This was referenced Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test cases would fail in the setup phase because on occasion, the same document was randomly generated twice (specifically, same timeseries and same timestamp). This change ensures that this no longer happen by generating each timestamp only once.
fixing