Rename transport version terminology #133492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit further tweaks terminology for the new file-based transport version system. Specially it renames: named -> referable unreferenced -> unreferable latest -> upper_bound
elasticsearchmachine
added
needs:triage
rjernst
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
added
auto-backport
elasticsearchmachine
added
the
serverless-linked
jdconrad
approved these changes
Aug 25, 2025
mark-vieira
approved these changes
Aug 25, 2025
...t/groovy/org/elasticsearch/gradle/internal/transport/AbstractTransportVersionFuncTest.groovy
Show resolved
Hide resolved
| for (var latestFile : stream.toList()) { | ||
| String contents = Files.readString(latestFile, StandardCharsets.UTF_8).strip(); | ||
| var latest = TransportVersionLatest.fromString(latestFile, contents); | ||
| var latest = TransportVersionUpperBound.fromString(latestFile, contents); |
There was a problem hiding this comment.
Should we also rename the local variables here to match?
💔 Backport failed
You can use sqren/backport to manually backport by running |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 26, 2025
This commit further tweaks terminology for the new file-based transport version system. Specially it renames: named -> referable unreferenced -> unreferable latest -> upper_bound
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 26, 2025
This commit further tweaks terminology for the new file-based transport version system. Specially it renames: named -> referable unreferenced -> unreferable latest -> upper_bound
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 26, 2025
This commit further tweaks terminology for the new file-based transport version system. Specially it renames: named -> referable unreferenced -> unreferable latest -> upper_bound
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 26, 2025
This commit further tweaks terminology for the new file-based transport version system. Specially it renames: named -> referable unreferenced -> unreferable latest -> upper_bound
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 26, 2025
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
This commit further tweaks terminology for the new file-based transport version system. Specially it renames: named -> referable unreferenced -> unreferable latest -> upper_bound
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
This commit further tweaks terminology for the new file-based transport version system. Specially it renames: named -> referable unreferenced -> unreferable latest -> upper_bound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit further tweaks terminology for the new file-based transport version system. Specially it renames:
named -> referable
unreferenced -> unreferable
latest -> upper_bound