-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add daily build pipeline for testing against next java EA version #133523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add daily build pipeline for testing against next java EA version #133523
Conversation
|
Pinging @elastic/es-delivery (Team:Delivery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one learning question
| - group: bwc | ||
| steps: $BWC_STEPS | ||
| - label: concurrent-search-tests | ||
| command: .ci/scripts/run-gradle.sh -Druntime.java=$$JAVA_EA_VERSION -Dbwc.checkout.align=true -Dtests.jvm.argline=-Des.concurrent_search=true -Des.concurrent_search=true functionalTests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does the double dollar sign mean in these files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its required due to the fact that we want that variable to be interpolated at build runtime and not at pipeine upload. The buildkite docs explain that briefly here: https://buildkite.com/docs/agent/v3/cli-pipeline#environment-variable-substitution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some questions, but I'll defer to others for approval as this is outside my area of expertise.
...-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
Show resolved
Hide resolved
catalog-info.yaml
Outdated
| kind: Pipeline | ||
| metadata: | ||
| description: ":elasticsearch: Tests and checks that are run daily against the latest Java EA builds" | ||
| name: elasticsearch / periodic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a pipeline with this name. Do these need to be unique?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
| apiVersion: backstage.io/v1alpha1 | ||
| kind: Resource | ||
| metadata: | ||
| name: buildkite-pipeline-elasticsearch-periodic-java-ea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have this as a separate pipeline instead of just adding it to the existing JVM matrix testing pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my understanding is that we want more coverage than just what we cover in the JVM matrix. like the full periodic coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cb602a8 to
7d71fdb
Compare
This includes a few fixes in the codebase to support java 25: - Update asm in plugin-scanner - Update ESVectorizationProvider to support java 25 - Update asm in plugin-cli
1765621 to
25ca0a6
Compare
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
…astic#133523) This adds buildkite pipeline coverage to test against the next major EA builds. This change includes a few changes to sort out some initial java 25 issues we face: - update asm to use a java 25 compatible version for plugin cli and plugin-scanner - tweak test infra to support java 25 (automatically adding add module support for vectors etc)
…astic#133523) This adds buildkite pipeline coverage to test against the next major EA builds. This change includes a few changes to sort out some initial java 25 issues we face: - update asm to use a java 25 compatible version for plugin cli and plugin-scanner - tweak test infra to support java 25 (automatically adding add module support for vectors etc) (cherry picked from commit 97bea1f)
…astic#133523) This adds buildkite pipeline coverage to test against the next major EA builds. This change includes a few changes to sort out some initial java 25 issues we face: - update asm to use a java 25 compatible version for plugin cli and plugin-scanner - tweak test infra to support java 25 (automatically adding add module support for vectors etc) (cherry picked from commit 97bea1f)
…33523) (#133876) This adds buildkite pipeline coverage to test against the next major EA builds. This change includes a few changes to sort out some initial java 25 issues we face: - update asm to use a java 25 compatible version for plugin cli and plugin-scanner - tweak test infra to support java 25 (automatically adding add module support for vectors etc) (cherry picked from commit 97bea1f)
…33523) (#133877) This adds buildkite pipeline coverage to test against the next major EA builds. This change includes a few changes to sort out some initial java 25 issues we face: - update asm to use a java 25 compatible version for plugin cli and plugin-scanner - tweak test infra to support java 25 (automatically adding add module support for vectors etc) (cherry picked from commit 97bea1f)
…astic#133523) This adds buildkite pipeline coverage to test against the next major EA builds. This change includes a few changes to sort out some initial java 25 issues we face: - update asm to use a java 25 compatible version for plugin cli and plugin-scanner - tweak test infra to support java 25 (automatically adding add module support for vectors etc) (cherry picked from commit 97bea1f) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java # libs/simdvec/src/main21/java/org/elasticsearch/simdvec/internal/vectorization/ESVectorizationProvider.java
…astic#133523) This adds buildkite pipeline coverage to test against the next major EA builds. This change includes a few changes to sort out some initial java 25 issues we face: - update asm to use a java 25 compatible version for plugin cli and plugin-scanner - tweak test infra to support java 25 (automatically adding add module support for vectors etc) (cherry picked from commit 97bea1f) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…33523) (#134071) This adds buildkite pipeline coverage to test against the next major EA builds. This change includes a few changes to sort out some initial java 25 issues we face: - update asm to use a java 25 compatible version for plugin cli and plugin-scanner - tweak test infra to support java 25 (automatically adding add module support for vectors etc) (cherry picked from commit 97bea1f) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
…33523) (#134070) This adds buildkite pipeline coverage to test against the next major EA builds. This change includes a few changes to sort out some initial java 25 issues we face: - update asm to use a java 25 compatible version for plugin cli and plugin-scanner - tweak test infra to support java 25 (automatically adding add module support for vectors etc) (cherry picked from commit 97bea1f) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java # libs/simdvec/src/main21/java/org/elasticsearch/simdvec/internal/vectorization/ESVectorizationProvider.java
…astic#133523) (elastic#134070) This adds buildkite pipeline coverage to test against the next major EA builds. This change includes a few changes to sort out some initial java 25 issues we face: - update asm to use a java 25 compatible version for plugin cli and plugin-scanner - tweak test infra to support java 25 (automatically adding add module support for vectors etc) (cherry picked from commit 97bea1f) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java # libs/simdvec/src/main21/java/org/elasticsearch/simdvec/internal/vectorization/ESVectorizationProvider.java
…astic#133523) (elastic#134070) This adds buildkite pipeline coverage to test against the next major EA builds. This change includes a few changes to sort out some initial java 25 issues we face: - update asm to use a java 25 compatible version for plugin cli and plugin-scanner - tweak test infra to support java 25 (automatically adding add module support for vectors etc) (cherry picked from commit 97bea1f) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java # libs/simdvec/src/main21/java/org/elasticsearch/simdvec/internal/vectorization/ESVectorizationProvider.java
BASE=04ea11bf39e125a3a1a9f7c35e2854dd8f4ba3a5 HEAD=25ca0a65fb995b4d2535a24476d9cc4ae55469dd Branch=main
BASE=04ea11bf39e125a3a1a9f7c35e2854dd8f4ba3a5 HEAD=25ca0a65fb995b4d2535a24476d9cc4ae55469dd Branch=main
BASE=04ea11bf39e125a3a1a9f7c35e2854dd8f4ba3a5 HEAD=25ca0a65fb995b4d2535a24476d9cc4ae55469dd Branch=main
BASE=04ea11bf39e125a3a1a9f7c35e2854dd8f4ba3a5 HEAD=25ca0a65fb995b4d2535a24476d9cc4ae55469dd Branch=main
BASE=04ea11bf39e125a3a1a9f7c35e2854dd8f4ba3a5 HEAD=25ca0a65fb995b4d2535a24476d9cc4ae55469dd Branch=main
BASE=04ea11bf39e125a3a1a9f7c35e2854dd8f4ba3a5 HEAD=25ca0a65fb995b4d2535a24476d9cc4ae55469dd Branch=main
This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:
An example run can be seen https://buildkite.com/elastic/elasticsearch-periodic/builds?branch=add-periodic-ea-coverage-pipeline
The pipeline does currently not succeed due to an issue in painless I have not nailed down yet and consider out of the scope of this work.