Skip to content

Conversation

@breskeby
Copy link
Contributor

@breskeby breskeby commented Aug 26, 2025

This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:

  • update asm to use a java 25 compatible version for plugin cli and plugin-scanner
  • tweak test infra to support java 25 (automatically adding add module support for vectors etc)

An example run can be seen https://buildkite.com/elastic/elasticsearch-periodic/builds?branch=add-periodic-ea-coverage-pipeline

The pipeline does currently not succeed due to an issue in painless I have not nailed down yet and consider out of the scope of this work.

@breskeby breskeby requested review from a team as code owners August 26, 2025 07:38
@breskeby breskeby added >non-issue :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team auto-backport Automatically create backport pull requests when merged v9.2.0 labels Aug 26, 2025
@breskeby breskeby self-assigned this Aug 26, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby changed the title WIP - Add periodic pipeline for testing java ea versions Add daily build pipeline for testing against next java EA version Aug 26, 2025
@breskeby breskeby requested a review from JVerwolf August 26, 2025 07:52
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one learning question

- group: bwc
steps: $BWC_STEPS
- label: concurrent-search-tests
command: .ci/scripts/run-gradle.sh -Druntime.java=$$JAVA_EA_VERSION -Dbwc.checkout.align=true -Dtests.jvm.argline=-Des.concurrent_search=true -Des.concurrent_search=true functionalTests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the double dollar sign mean in these files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its required due to the fact that we want that variable to be interpolated at build runtime and not at pipeine upload. The buildkite docs explain that briefly here: https://buildkite.com/docs/agent/v3/cli-pipeline#environment-variable-substitution

Copy link
Contributor

@JVerwolf JVerwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some questions, but I'll defer to others for approval as this is outside my area of expertise.

kind: Pipeline
metadata:
description: ":elasticsearch: Tests and checks that are run daily against the latest Java EA builds"
name: elasticsearch / periodic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a pipeline with this name. Do these need to be unique?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

apiVersion: backstage.io/v1alpha1
kind: Resource
metadata:
name: buildkite-pipeline-elasticsearch-periodic-java-ea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have this as a separate pipeline instead of just adding it to the existing JVM matrix testing pipeline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my understanding is that we want more coverage than just what we cover in the JVM matrix. like the full periodic coverage

Copy link
Contributor Author

@breskeby breskeby Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we think the normal coverage is enough I'm happy to adjust this and just incorporate that in existing pipelines. // cc @JVerwolf @rjernst

@breskeby breskeby force-pushed the add-periodic-ea-coverage-pipeline branch 2 times, most recently from cb602a8 to 7d71fdb Compare August 28, 2025 16:59
This includes a few fixes in the codebase to support java 25:

- Update asm in plugin-scanner
- Update ESVectorizationProvider to support java 25
- Update asm in plugin-cli
@breskeby breskeby force-pushed the add-periodic-ea-coverage-pipeline branch from 1765621 to 25ca0a6 Compare August 29, 2025 07:38
@breskeby breskeby merged commit 97bea1f into elastic:main Aug 29, 2025
33 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 133523

JeremyDahlgren pushed a commit to JeremyDahlgren/elasticsearch that referenced this pull request Aug 29, 2025
…astic#133523)

This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:

- update asm to use a java 25 compatible version for plugin cli and plugin-scanner
- tweak test infra to support java 25 (automatically adding add module support for vectors etc)
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Aug 30, 2025
…astic#133523)

This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:

- update asm to use a java 25 compatible version for plugin cli and plugin-scanner
- tweak test infra to support java 25 (automatically adding add module support for vectors etc)

(cherry picked from commit 97bea1f)
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Aug 30, 2025
…astic#133523)

This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:

- update asm to use a java 25 compatible version for plugin cli and plugin-scanner
- tweak test infra to support java 25 (automatically adding add module support for vectors etc)

(cherry picked from commit 97bea1f)
breskeby added a commit that referenced this pull request Sep 1, 2025
…33523) (#133876)

This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:

- update asm to use a java 25 compatible version for plugin cli and plugin-scanner
- tweak test infra to support java 25 (automatically adding add module support for vectors etc)

(cherry picked from commit 97bea1f)
breskeby added a commit that referenced this pull request Sep 1, 2025
…33523) (#133877)

This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:

- update asm to use a java 25 compatible version for plugin cli and plugin-scanner
- tweak test infra to support java 25 (automatically adding add module support for vectors etc)

(cherry picked from commit 97bea1f)
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Sep 3, 2025
…astic#133523)

This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:

- update asm to use a java 25 compatible version for plugin cli and plugin-scanner
- tweak test infra to support java 25 (automatically adding add module support for vectors etc)

(cherry picked from commit 97bea1f)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
#	libs/simdvec/src/main21/java/org/elasticsearch/simdvec/internal/vectorization/ESVectorizationProvider.java
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Sep 3, 2025
…astic#133523)

This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:

- update asm to use a java 25 compatible version for plugin cli and plugin-scanner
- tweak test infra to support java 25 (automatically adding add module support for vectors etc)

(cherry picked from commit 97bea1f)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
@breskeby
Copy link
Contributor Author

breskeby commented Sep 3, 2025

💚 All backports created successfully

Status Branch Result
8.19
8.18

Questions ?

Please refer to the Backport tool documentation

breskeby added a commit that referenced this pull request Sep 3, 2025
…33523) (#134071)

This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:

- update asm to use a java 25 compatible version for plugin cli and plugin-scanner
- tweak test infra to support java 25 (automatically adding add module support for vectors etc)

(cherry picked from commit 97bea1f)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
breskeby added a commit that referenced this pull request Sep 3, 2025
…33523) (#134070)

This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:

- update asm to use a java 25 compatible version for plugin cli and plugin-scanner
- tweak test infra to support java 25 (automatically adding add module support for vectors etc)

(cherry picked from commit 97bea1f)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
#	libs/simdvec/src/main21/java/org/elasticsearch/simdvec/internal/vectorization/ESVectorizationProvider.java
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Sep 11, 2025
…astic#133523) (elastic#134070)

This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:

- update asm to use a java 25 compatible version for plugin cli and plugin-scanner
- tweak test infra to support java 25 (automatically adding add module support for vectors etc)

(cherry picked from commit 97bea1f)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
#	libs/simdvec/src/main21/java/org/elasticsearch/simdvec/internal/vectorization/ESVectorizationProvider.java
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Sep 19, 2025
…astic#133523) (elastic#134070)

This adds buildkite pipeline coverage to test against the next major EA builds.
This change includes a few changes to sort out some initial java 25 issues we face:

- update asm to use a java 25 compatible version for plugin cli and plugin-scanner
- tweak test infra to support java 25 (automatically adding add module support for vectors etc)

(cherry picked from commit 97bea1f)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
#	libs/simdvec/src/main21/java/org/elasticsearch/simdvec/internal/vectorization/ESVectorizationProvider.java
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 23, 2025
BASE=04ea11bf39e125a3a1a9f7c35e2854dd8f4ba3a5
HEAD=25ca0a65fb995b4d2535a24476d9cc4ae55469dd
Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 2, 2025
BASE=04ea11bf39e125a3a1a9f7c35e2854dd8f4ba3a5
HEAD=25ca0a65fb995b4d2535a24476d9cc4ae55469dd
Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 2, 2025
BASE=04ea11bf39e125a3a1a9f7c35e2854dd8f4ba3a5
HEAD=25ca0a65fb995b4d2535a24476d9cc4ae55469dd
Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 8, 2025
BASE=04ea11bf39e125a3a1a9f7c35e2854dd8f4ba3a5
HEAD=25ca0a65fb995b4d2535a24476d9cc4ae55469dd
Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 17, 2025
BASE=04ea11bf39e125a3a1a9f7c35e2854dd8f4ba3a5
HEAD=25ca0a65fb995b4d2535a24476d9cc4ae55469dd
Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 23, 2025
BASE=04ea11bf39e125a3a1a9f7c35e2854dd8f4ba3a5
HEAD=25ca0a65fb995b4d2535a24476d9cc4ae55469dd
Branch=main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants