[Gradle] Avoid usage of archives configuration #133526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be deprecated in later Gradle versions
breskeby
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
commented
Aug 26, 2025
| } | ||
| } | ||
|
|
||
| ['archives:windows-zip', |
There was a problem hiding this comment.
We don't use it and its basically just some rewiring of configurations adding nothing but clutter to the build that can be avoided.
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Gradle build configuration by replacing the deprecated archives configuration with the standard assemble task dependency pattern. This change prepares the codebase for future Gradle versions where the archives configuration will be removed.
- Replaces
artifacts { archives taskName }withtasks.named('assemble').configure { dependsOn taskName } - Removes legacy configuration setup for distribution subprojects
- Maintains the same build behavior while using the recommended Gradle approach
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| x-pack/rest-resources-zip/build.gradle | Updates restResourcesZip task to use assemble dependency instead of archives configuration |
| x-pack/plugin/security/build.gradle | Updates jar task publishing to use assemble dependency instead of archives configuration |
| x-pack/plugin/ml/build.gradle | Updates jar task publishing to use assemble dependency instead of archives configuration |
| distribution/build.gradle | Removes legacy archives configuration setup for distribution subprojects |
Comments suppressed due to low confidence (2)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
breskeby
commented
Aug 26, 2025
| // normal es plugins do not publish the jar but we need to since users need it for extensions | ||
| archives tasks.named("jar") | ||
|
|
||
| tasks.named('assemble').configure { |
There was a problem hiding this comment.
buildReleaseArtifacts relies on the assemble task. archives has been deprecated. see gradle/gradle#34001
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 26, 2025
* [Gradle] Avoid usage of archives configuration This will be deprecated in later Gradle versions * Remove unused wiring in distribution project * minor tweak
This was referenced Aug 26, 2025
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 26, 2025
* [Gradle] Avoid usage of archives configuration This will be deprecated in later Gradle versions * Remove unused wiring in distribution project * minor tweak
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 26, 2025
* [Gradle] Avoid usage of archives configuration This will be deprecated in later Gradle versions * Remove unused wiring in distribution project * minor tweak
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 26, 2025
* [Gradle] Avoid usage of archives configuration This will be deprecated in later Gradle versions * Remove unused wiring in distribution project * minor tweak
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 26, 2025
* [Gradle] Avoid usage of archives configuration This will be deprecated in later Gradle versions * Remove unused wiring in distribution project * minor tweak
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 29, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 29, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 29, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 29, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 4, 2025
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
…tic#133568) * [Gradle] Avoid usage of archives configuration This will be deprecated in later Gradle versions * Remove unused wiring in distribution project * minor tweak
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
…tic#133568) * [Gradle] Avoid usage of archives configuration This will be deprecated in later Gradle versions * Remove unused wiring in distribution project * minor tweak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be deprecated in later Gradle versions