Skip to content

[9.0] Use safe double range to test long mapper (#133423) #133584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
Merged

[9.0] Use safe double range to test long mapper (#133423) #133584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ public void testLongIndexingCoercesIntoRange() throws Exception {
assertThat(doc.rootDoc().getFields("field"), hasSize(1));
}

// This is the biggest long that double can represent exactly
public static final long MAX_SAFE_LONG_FOR_DOUBLE = 1L << 53;

@Override
protected Number randomNumber() {
if (randomBoolean()) {
Expand All @@ -112,8 +115,8 @@ protected Number randomNumber() {
if (randomBoolean()) {
return randomDouble();
}
assumeFalse("https://github.com/elastic/elasticsearch/issues/70585", true);
return randomDoubleBetween(Long.MIN_VALUE, Long.MAX_VALUE, true);
// TODO: increase the range back to full LONG range once https://github.com/elastic/elasticsearch/issues/132893 is fixed
return randomDoubleBetween(-MAX_SAFE_LONG_FOR_DOUBLE, MAX_SAFE_LONG_FOR_DOUBLE, true);
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/70585")
Expand Down