Skip to content

Throw away test dates with year greater than 9999 #133615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 27, 2025
Merged

Throw away test dates with year greater than 9999 #133615

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
528721d
Throw away test dates with year greater than 9999
parkertimmins Aug 27, 2025
063fddf
[CI] Auto commit changes from spotless
Aug 27, 2025
ed3583d
use randomValueOtherThanMany
parkertimmins Aug 27, 2025
58db0d6
[CI] Auto commit changes from spotless
Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .../java/org/elasticsearch/xpack/logsdb/patternedtext/PatternedTextVsMatchOnlyTextTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,15 @@ private static String randomSeparator() {
}

private static String randomTimestamp() {
long millis = randomMillisUpToYear9999();
ZonedDateTime zonedDateTime = ZonedDateTime.ofInstant(Instant.ofEpochMilli(millis), randomZone());
ZonedDateTime zonedDateTime;
Copy link
Member

@dnhatn dnhatn Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe use randomValueOtherThanMany?

Copy link
Contributor Author

@parkertimmins parkertimmins Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dnhatn! Oh nice, randomValueOtherThanMany makes it much cleaner

do {
long millis = randomMillisUpToYear9999();
zonedDateTime = ZonedDateTime.ofInstant(Instant.ofEpochMilli(millis), randomZone());

// The random millis are below year 10000 in UTC, but if the date is within 1 day of year 10000, the year can be 10000 in the
// selected timezone. Since the date formatter cannot handle years greater than 9999, select another date.
} while (zonedDateTime.getYear() == 10000);

DateFormatter formatter = DateFormatter.forPattern(randomDateFormatterPattern()).withLocale(randomLocale(random()));
return formatter.format(zonedDateTime);
}
Expand Down