Skip to content

Conversation

DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Aug 27, 2025

Today we report having disconnected from a node along with the root
cause, typically something like SocketException: Connection reset, but
this does not identify the affected TCP channel. When troubleshooting,
e.g. using packet captures, we may need to know the details of the TCP
endpoints in order to identify the problematic traffic. This commit adds
a NodeDisconnectedException wrapper around the root cause whose
message identifies the exact TCP channel.

Today we report having disconnected from a node along with the root
cause, typically a `SocketException`, but for troubleshooting purposes
we may also need to identify the exact TCP channel which was affected by
the exception. This commit adds a `NodeDisconnectedException` wrapper to
add the additional details.
@DaveCTurner DaveCTurner requested a review from schase-es August 27, 2025 09:01
@DaveCTurner DaveCTurner added >non-issue :Distributed Coordination/Network Http and internode communication implementations auto-backport Automatically create backport pull requests when merged v9.2.0 v9.1.4 v8.19.4 labels Aug 27, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Aug 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@DaveCTurner DaveCTurner requested a review from mhl-b August 29, 2025 21:03
Copy link
Contributor

@mhl-b mhl-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 2, 2025
@DaveCTurner DaveCTurner merged commit d6c0fbd into elastic:main Sep 2, 2025
33 checks passed
@DaveCTurner DaveCTurner deleted the 2025/08/27/channel-close-exception-message branch September 2, 2025 18:53
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Sep 2, 2025
Today we report having disconnected from a node along with the root
cause, typically a `SocketException`, but for troubleshooting purposes
we may also need to identify the exact TCP channel which was affected by
the exception. This commit adds a `NodeDisconnectedException` wrapper to
add the additional details.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Sep 2, 2025
Today we report having disconnected from a node along with the root
cause, typically a `SocketException`, but for troubleshooting purposes
we may also need to identify the exact TCP channel which was affected by
the exception. This commit adds a `NodeDisconnectedException` wrapper to
add the additional details.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.1
8.19

elasticsearchmachine pushed a commit that referenced this pull request Sep 2, 2025
Today we report having disconnected from a node along with the root
cause, typically a `SocketException`, but for troubleshooting purposes
we may also need to identify the exact TCP channel which was affected by
the exception. This commit adds a `NodeDisconnectedException` wrapper to
add the additional details.
elasticsearchmachine pushed a commit that referenced this pull request Sep 3, 2025
Today we report having disconnected from a node along with the root
cause, typically a `SocketException`, but for troubleshooting purposes
we may also need to identify the exact TCP channel which was affected by
the exception. This commit adds a `NodeDisconnectedException` wrapper to
add the additional details.
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Sep 11, 2025
…ic#134011)

Today we report having disconnected from a node along with the root
cause, typically a `SocketException`, but for troubleshooting purposes
we may also need to identify the exact TCP channel which was affected by
the exception. This commit adds a `NodeDisconnectedException` wrapper to
add the additional details.
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Sep 19, 2025
…ic#134011)

Today we report having disconnected from a node along with the root
cause, typically a `SocketException`, but for troubleshooting purposes
we may also need to identify the exact TCP channel which was affected by
the exception. This commit adds a `NodeDisconnectedException` wrapper to
add the additional details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Network Http and internode communication implementations >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team v8.19.4 v9.1.4 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants