-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Describe closing channel in exception message #133632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DaveCTurner
merged 2 commits into
elastic:main
from
DaveCTurner:2025/08/27/channel-close-exception-message
Sep 2, 2025
Merged
Describe closing channel in exception message #133632
DaveCTurner
merged 2 commits into
elastic:main
from
DaveCTurner:2025/08/27/channel-close-exception-message
Sep 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we report having disconnected from a node along with the root cause, typically a `SocketException`, but for troubleshooting purposes we may also need to identify the exact TCP channel which was affected by the exception. This commit adds a `NodeDisconnectedException` wrapper to add the additional details.
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
mhl-b
approved these changes
Sep 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 2, 2025
Today we report having disconnected from a node along with the root cause, typically a `SocketException`, but for troubleshooting purposes we may also need to identify the exact TCP channel which was affected by the exception. This commit adds a `NodeDisconnectedException` wrapper to add the additional details.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 2, 2025
Today we report having disconnected from a node along with the root cause, typically a `SocketException`, but for troubleshooting purposes we may also need to identify the exact TCP channel which was affected by the exception. This commit adds a `NodeDisconnectedException` wrapper to add the additional details.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 2, 2025
Today we report having disconnected from a node along with the root cause, typically a `SocketException`, but for troubleshooting purposes we may also need to identify the exact TCP channel which was affected by the exception. This commit adds a `NodeDisconnectedException` wrapper to add the additional details.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 3, 2025
Today we report having disconnected from a node along with the root cause, typically a `SocketException`, but for troubleshooting purposes we may also need to identify the exact TCP channel which was affected by the exception. This commit adds a `NodeDisconnectedException` wrapper to add the additional details.
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
…ic#134011) Today we report having disconnected from a node along with the root cause, typically a `SocketException`, but for troubleshooting purposes we may also need to identify the exact TCP channel which was affected by the exception. This commit adds a `NodeDisconnectedException` wrapper to add the additional details.
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
…ic#134011) Today we report having disconnected from a node along with the root cause, typically a `SocketException`, but for troubleshooting purposes we may also need to identify the exact TCP channel which was affected by the exception. This commit adds a `NodeDisconnectedException` wrapper to add the additional details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Distributed Coordination/Network
Http and internode communication implementations
>non-issue
Team:Distributed Coordination
Meta label for Distributed Coordination team
v8.19.4
v9.1.4
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we report having disconnected from a node along with the root
cause, typically something like
SocketException: Connection reset
, butthis does not identify the affected TCP channel. When troubleshooting,
e.g. using packet captures, we may need to know the details of the TCP
endpoints in order to identify the problematic traffic. This commit adds
a
NodeDisconnectedException
wrapper around the root cause whosemessage identifies the exact TCP channel.