Update FIRST and LAST to accept keyword and text
#133642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.2.0
needs:triage
romulets
added
>feature
Team:Analytics
romulets
changed the title
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
romulets
changed the title
FIRST and LAST to accept keyword
romulets
force-pushed
the
first-last-keyword
branch
from
b3621e8 to
4e61eab
Compare
romulets
commented
Aug 27, 2025
.../generated-src/org/elasticsearch/compute/aggregation/FirstBytesRefByTimestampAggregator.java
Outdated
Show resolved
Hide resolved
romulets
commented
Aug 27, 2025
.../generated-src/org/elasticsearch/compute/aggregation/FirstBytesRefByTimestampAggregator.java
Show resolved
Hide resolved
nik9000
reviewed
Aug 27, 2025
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/X-2State.java.st
Outdated
Show resolved
Hide resolved
...ute/src/main/java/org/elasticsearch/compute/aggregation/X-ValueByTimestampAggregator.java.st
Outdated
Show resolved
Hide resolved
...ute/src/main/java/org/elasticsearch/compute/aggregation/X-ValueByTimestampAggregator.java.st
Outdated
Show resolved
Hide resolved
...ute/src/main/java/org/elasticsearch/compute/aggregation/X-ValueByTimestampAggregator.java.st
Outdated
Show resolved
Hide resolved
romulets
force-pushed
the
first-last-keyword
branch
from
a96304c to
84ee794
Compare
nik9000
reviewed
Aug 28, 2025
x-pack/plugin/esql/qa/testFixtures/src/main/resources/stats_last.csv-spec
Show resolved
Hide resolved
romulets
changed the title
FIRST and LAST to accept keywordFIRST and LAST to accept keyword and text
romulets
force-pushed
the
first-last-keyword
branch
from
7404778 to
a4e9fcb
Compare
nik9000
approved these changes
Aug 28, 2025
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/X-2State.java.st
Outdated
Show resolved
Hide resolved
romulets
force-pushed
the
first-last-keyword
branch
from
81b4017 to
2aac264
Compare
romulets
force-pushed
the
first-last-keyword
branch
from
f9960f2 to
5ff4fe5
Compare
romulets
force-pushed
the
first-last-keyword
branch
from
35c0fbb to
1a671e5
Compare
JeremyDahlgren
pushed a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
Aug 29, 2025
* add first and last by timestamp * receive breaker via driverContext * rearrange attributes to touch less files * create and release only one BreakingBytesRefBuilder per group * [CI] Auto commit changes from spotless * Use BreakingBytesRefBuilder in LongBytesRefState * Add tests for text * Add unit tests * Add label to circuit breaker * Format code * Label strings functionality to not fail tests * sort ip test to keep consistent * sort last and first test to keep it consistent --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #132603 enable keyword and text to be used in
FIRSTandLAST.Relates to