Skip to content

[DiskBBQ] Change IOContext.DEFAULT.withReadAdvice(ReadAdvice.SEQUENTIAL) with IOContext.READONCE #133666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2025
Merged

[DiskBBQ] Change IOContext.DEFAULT.withReadAdvice(ReadAdvice.SEQUENTIAL) with IOContext.READONCE #133666

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01518e6
[DiskBBQ] Change IOContext.DEFAULT.withReadAdvice(ReadAdvice.SEQUENTI…
iverase Aug 27, 2025
3e5ea69
Merge branch 'main' into ReadAdvice
iverase Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions server/src/main/java/org/elasticsearch/index/codec/vectors/IVFVectorsWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.IndexOutput;
import org.apache.lucene.store.RandomAccessInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.LongValues;
import org.apache.lucene.util.VectorUtil;
import org.elasticsearch.core.IOUtils;
Expand Down Expand Up @@ -300,13 +299,8 @@ private void mergeOneFieldIVF(FieldInfo fieldInfo, MergeState mergeState) throws
// Even when the file might be sample, the reads will be always in increase order, therefore we set the ReadAdvice to SEQUENTIAL
// so the OS can optimize read ahead in low memory situations.
try (
IndexInput vectors = mergeState.segmentInfo.dir.openInput(
tempRawVectorsFileName,
IOContext.DEFAULT.withReadAdvice(ReadAdvice.SEQUENTIAL)
);
IndexInput docs = docsFileName == null
? null
: mergeState.segmentInfo.dir.openInput(docsFileName, IOContext.DEFAULT.withReadAdvice(ReadAdvice.SEQUENTIAL))
IndexInput vectors = mergeState.segmentInfo.dir.openInput(tempRawVectorsFileName, IOContext.READONCE);
IndexInput docs = docsFileName == null ? null : mergeState.segmentInfo.dir.openInput(docsFileName, IOContext.READONCE)
Comment on lines +302 to +303
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK. None of the inputs are accessed from a different thread other than this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, and this is changing very soon with the new API.

) {
final FloatVectorValues floatVectorValues = getFloatVectorValues(fieldInfo, docs, vectors, numVectors);

Expand Down