Skip to content

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Aug 27, 2025

This PR updates the semantic query to support querying multiple inference IDs, which can happen when querying semantic_text fields across multiple indices. This is enabled by transferring inference results between coordinating and data nodes using a map keyed on inference ID.

This change also benefits match query support since such queries are rewritten to semantic queries when a semantic_text field is targeted. With this change, it should be possible to issue a multi-index match query against semantic_text fields that use multiple inference IDs.

@Mikep86 Mikep86 added >enhancement :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v9.2.0 labels Aug 27, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search - Relevance The Search organization Search Relevance team label Aug 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@elasticsearchmachine
Copy link
Collaborator

Hi @Mikep86, I've created a changelog YAML for you.

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

It looks like there are some failing tests that should be cleaned up, and I'd like to see a followup PR that removes the artificial restriction in interceptors.

Otherwise, nice work! 🙌

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @Mikep86! I left one comment regarding the need of the new writables, a plain map would make things easier to read and would avoid all the boiler plates of these interfaces.

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mikep86
Copy link
Contributor Author

Mikep86 commented Sep 2, 2025

@elasticmachine Update branch

@Mikep86
Copy link
Contributor Author

Mikep86 commented Sep 2, 2025

@elasticmachine update branch

@Mikep86
Copy link
Contributor Author

Mikep86 commented Sep 2, 2025

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

merge conflict between base and head

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@Mikep86 Mikep86 merged commit 3bcf194 into elastic:main Sep 3, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>enhancement :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants