Skip to content

Fix TimeValue comparisons for -1 duration #133677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 3, 2025
Merged

Fix TimeValue comparisons for -1 duration #133677

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bb2687d
Fix TimeValue comparisons for -1 duration
JeremyDahlgren Aug 27, 2025
6d2003f
Merge branch 'main' into timevalue-negative-1-sec-equals-failure
JeremyDahlgren Aug 27, 2025
0617633
Merge branch 'main' into timevalue-negative-1-sec-equals-failure
JeremyDahlgren Aug 27, 2025
853fb90
Revert change to compareTo(), add units in getStringRep()
JeremyDahlgren Aug 28, 2025
47bcf11
Merge branch 'main' into timevalue-negative-1-sec-equals-failure
JeremyDahlgren Aug 28, 2025
c938f60
Keep MINUS_ONE (milliseconds) as "-1"
JeremyDahlgren Aug 29, 2025
e429bf3
Merge branch 'main' into timevalue-negative-1-sec-equals-failure
JeremyDahlgren Aug 29, 2025
c336e77
Fix test using -1 with units
JeremyDahlgren Aug 29, 2025
05c4024
Merge branch 'main' into timevalue-negative-1-sec-equals-failure
JeremyDahlgren Sep 3, 2025
6b8059f
Merge branch 'main' into timevalue-negative-1-sec-equals-failure
JeremyDahlgren Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libs/core/src/main/java/org/elasticsearch/core/TimeValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,9 @@ public static long nsecToMSec(long ns) {

@Override
public int compareTo(TimeValue timeValue) {
if (duration == -1L && timeValue.duration == -1L) {
return 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also handle one being -1 and the other not?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok: if one is negative and the other is non-negative then the negative one will correctly compare as less than the non-negative one already.

}
double thisValue = ((double) duration) * timeUnit.toNanos(1);
double otherValue = ((double) timeValue.duration) * timeValue.timeUnit.toNanos(1);
return Double.compare(thisValue, otherValue);
Expand Down
7 changes: 7 additions & 0 deletions libs/core/src/test/java/org/elasticsearch/common/unit/TimeValueTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ public void testToString() {

public void testMinusOne() {
assertThat(new TimeValue(-1).nanos(), lessThan(0L));
assertThat(TimeValue.timeValueNanos(-1), equalTo(TimeValue.MINUS_ONE));
assertThat(TimeValue.timeValueMillis(-1), equalTo(TimeValue.MINUS_ONE));
assertThat(TimeValue.timeValueSeconds(-1), equalTo(TimeValue.MINUS_ONE));
assertThat(TimeValue.timeValueMinutes(-1), equalTo(TimeValue.MINUS_ONE));
assertThat(TimeValue.timeValueHours(-1), equalTo(TimeValue.MINUS_ONE));
assertThat(TimeValue.timeValueDays(-1), equalTo(TimeValue.MINUS_ONE));
}

public void testParseTimeValue() {
Expand Down Expand Up @@ -109,6 +115,7 @@ public void testRoundTrip() {
assertThat(TimeValue.parseTimeValue(s, null, "test").getStringRep(), equalTo(s));
final TimeValue t = new TimeValue(randomIntBetween(1, 128), randomFrom(TimeUnit.values()));
assertThat(TimeValue.parseTimeValue(t.getStringRep(), null, "test"), equalTo(t));
assertThat(TimeValue.timeValueSeconds(-1), equalTo(TimeValue.parseTimeValue(TimeValue.timeValueSeconds(-1).getStringRep(), "foo")));
}

private static final String FRACTIONAL_TIME_VALUES_ARE_NOT_SUPPORTED = "fractional time values are not supported";
Expand Down