Add positions index_option to patterned_text #133679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkertimmins
added
>non-issue
:StorageEngine/Mapping
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Aug 28, 2025
x-pack/plugin/logsdb/src/yamlRestTest/resources/rest-api-spec/test/patternedtext/10_basic.yml
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Aug 28, 2025
...sdb/src/main/java/org/elasticsearch/xpack/logsdb/patternedtext/PatternedTextFieldMapper.java
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Aug 28, 2025
Contributor
kkrik-es
left a comment
kkrik-es
left a comment
There was a problem hiding this comment.
Looks good, modulo the default mode.
kkrik-es
approved these changes
Aug 29, 2025
martijnvg
approved these changes
Aug 29, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM 👍 , Let's add a variant of the patterned text benchmark with positions as well?
JeremyDahlgren
pushed a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
Aug 29, 2025
Add an index_options field to patterned_text type. Currently, only supports docs and positions. When docs is enabled, positions are not stored, and queries fall back to a source confirmed query, like match_only_text. With positions enabled, phrase queries are efficient as the source does not need to be checked. Defaults to docs. Fixes elastic#128935
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
index_optionsfield topatterned_texttype. Currently, only supportsdocsandpositions. Whendocsis enabled, positions are not stored, and queries fall back to a source confirmed query, like match_only_text. Withpositionsenabled, phrase queries are efficient as the source does not need to be checked. Defaults todocs.Fixes #128935