Drop testFetchCoerced #133688
Merged
Drop testFetchCoerced #133688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess with that code. So let's just drop it - if we ever do dare to change the conversion code, we can add proper tests then.
smalyshev
added
>test
elasticsearchmachine
added
Team:StorageEngine
Team:Search Foundations
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
smalyshev
added
v9.2.0
auto-backport
nik9000
approved these changes
Aug 28, 2025
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Aug 28, 2025
…ess with that code. (elastic#133688) So let's just drop it - if we ever do dare to change the conversion code, we can add proper tests then. (cherry picked from commit 50c3cd4) # Conflicts: # muted-tests.yml # server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Aug 28, 2025
…ess with that code. (elastic#133688) So let's just drop it - if we ever do dare to change the conversion code, we can add proper tests then. (cherry picked from commit 50c3cd4) # Conflicts: # muted-tests.yml # server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Aug 28, 2025
…ess with that code. (elastic#133688) So let's just drop it - if we ever do dare to change the conversion code, we can add proper tests then. (cherry picked from commit 50c3cd4) # Conflicts: # muted-tests.yml # server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Aug 28, 2025
…ess with that code. (elastic#133688) So let's just drop it - if we ever do dare to change the conversion code, we can add proper tests then. (cherry picked from commit 50c3cd4) # Conflicts: # muted-tests.yml # server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
…ess with that code. (elastic#133688) (elastic#133726) So let's just drop it - if we ever do dare to change the conversion code, we can add proper tests then. (cherry picked from commit 50c3cd4) # Conflicts: # muted-tests.yml # server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
…ess with that code. (elastic#133688) (elastic#133726) So let's just drop it - if we ever do dare to change the conversion code, we can add proper tests then. (cherry picked from commit 50c3cd4) # Conflicts: # muted-tests.yml # server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't look like this test has ever worked, and nobody wants to mess with that code.
So let's just drop it - if we ever do dare to change the conversion code, we can add proper tests then.
Closes #132893