Remove upper limit for chunking settings #133718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kderusso, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
reviewed
Aug 28, 2025
| ChunkingSettings chunkingSettings | ||
| ) { | ||
| super(inferenceEntityId, taskType, service, serviceSettings, taskSettings, chunkingSettings); | ||
| if (chunkingSettings != null && chunkingSettings.maxChunkSize() != null) { |
There was a problem hiding this comment.
Please add the same check to MultilingualE5SmallModel so multilingual-e5-small will also pick up the restriction.
DonalEvans
reviewed
Aug 28, 2025
| return field; | ||
| } | ||
|
|
||
| public static Integer extractRequiredPositiveIntegerGreaterThanOrEqualToMin( |
There was a problem hiding this comment.
Would it be possible to add some tests for this new method?
DonalEvans
approved these changes
Aug 28, 2025
JeremyDahlgren
pushed a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boundary for chunking settings was set at a max chunk size of 300, which is too small for many models with large window sizes. This PR removes that cap, and instead enforces a cap for ELSER models so they are not truncated.