Skip to content

ESQL: Fix BasicBlockTests #133743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 3, 2025
Merged

ESQL: Fix BasicBlockTests #133743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4857ad2
ESQL: Fix BasicBlockTests
nik9000 Aug 28, 2025
0458559
Merge branch 'main' into fix_basic_block_tests
nik9000 Aug 28, 2025
e23a15f
Keep
nik9000 Aug 28, 2025
e25e524
Merge branch 'main' into fix_basic_block_tests
nik9000 Sep 3, 2025
7a96e55
Merge branch 'main' into fix_basic_block_tests
nik9000 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,24 +495,9 @@ tests:
- class: org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryStopIT
method: testStopQueryLocal
issue: https://github.com/elastic/elasticsearch/issues/133481
- class: org.elasticsearch.compute.data.BasicBlockTests
method: testIntBlock
issue: https://github.com/elastic/elasticsearch/issues/133596
- class: org.elasticsearch.compute.data.BasicBlockTests
method: testDoubleBlock
issue: https://github.com/elastic/elasticsearch/issues/133606
- class: org.elasticsearch.compute.data.BasicBlockTests
method: testBooleanBlock
issue: https://github.com/elastic/elasticsearch/issues/133608
- class: org.elasticsearch.compute.data.BasicBlockTests
method: testLongBlock
issue: https://github.com/elastic/elasticsearch/issues/133618
- class: org.elasticsearch.xpack.esql.inference.rerank.RerankOperatorTests
method: testSimpleCircuitBreaking
issue: https://github.com/elastic/elasticsearch/issues/133619
- class: org.elasticsearch.compute.data.BasicBlockTests
method: testFloatBlock
issue: https://github.com/elastic/elasticsearch/issues/133621
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT
method: test
issue: https://github.com/elastic/elasticsearch/issues/133077
Expand Down
11 changes: 7 additions & 4 deletions x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/data/BasicBlockTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1784,10 +1784,13 @@ public static Block assertDeepCopy(Block block) {
try (Block deepCopy = block.deepCopy(into)) {
assertThat(deepCopy, equalTo(block));

assertThat(
deepCopy.asVector() != null && deepCopy.asVector().isConstant(),
equalTo(block.asVector() != null && block.asVector().isConstant())
);
if (block.asVector() != null && block.asVector().isConstant()) {
/*
* If we were a constant, we will still be one. If we were not a constant,
* deepCopy might make a constant in the rare case that we have a single element array.
*/
assertThat(deepCopy.asVector() != null && deepCopy.asVector().isConstant(), equalTo(true));
}
}
Block untracked = block.deepCopy(TestBlockFactory.getNonBreakingInstance());
assertThat(untracked, equalTo(block));
Expand Down