-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Run snyk check in periodic build for each development branch #133751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we filter by regex for common name pattern of the dev branches to reduce risk of running from development branch. in reality those periodic builds are not likely to be triggered by developers so this is a good enough compromise. Branches that are not developed anymore will stay in snyk for now and require manual removal.
Pinging @elastic/es-delivery (Team:Delivery) |
slobodanadamovic
approved these changes
Aug 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Neat!
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 28, 2025
…#133751) we filter by regex for common name pattern of the dev branches to reduce risk of running from development branch. in reality those periodic builds are not likely to be triggered by developers so this is a good enough compromise. Branches that are not developed anymore will stay in snyk for now and require manual removal.
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 28, 2025
…#133751) we filter by regex for common name pattern of the dev branches to reduce risk of running from development branch. in reality those periodic builds are not likely to be triggered by developers so this is a good enough compromise. Branches that are not developed anymore will stay in snyk for now and require manual removal.
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 28, 2025
…#133751) we filter by regex for common name pattern of the dev branches to reduce risk of running from development branch. in reality those periodic builds are not likely to be triggered by developers so this is a good enough compromise. Branches that are not developed anymore will stay in snyk for now and require manual removal.
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 28, 2025
…#133751) we filter by regex for common name pattern of the dev branches to reduce risk of running from development branch. in reality those periodic builds are not likely to be triggered by developers so this is a good enough compromise. Branches that are not developed anymore will stay in snyk for now and require manual removal.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 28, 2025
#133756) we filter by regex for common name pattern of the dev branches to reduce risk of running from development branch. in reality those periodic builds are not likely to be triggered by developers so this is a good enough compromise. Branches that are not developed anymore will stay in snyk for now and require manual removal.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 28, 2025
#133757) we filter by regex for common name pattern of the dev branches to reduce risk of running from development branch. in reality those periodic builds are not likely to be triggered by developers so this is a good enough compromise. Branches that are not developed anymore will stay in snyk for now and require manual removal.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 28, 2025
#133754) we filter by regex for common name pattern of the dev branches to reduce risk of running from development branch. in reality those periodic builds are not likely to be triggered by developers so this is a good enough compromise. Branches that are not developed anymore will stay in snyk for now and require manual removal.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 28, 2025
#133755) we filter by regex for common name pattern of the dev branches to reduce risk of running from development branch. in reality those periodic builds are not likely to be triggered by developers so this is a good enough compromise. Branches that are not developed anymore will stay in snyk for now and require manual removal.
JeremyDahlgren
pushed a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
Aug 29, 2025
…#133751) we filter by regex for common name pattern of the dev branches to reduce risk of running from development branch. in reality those periodic builds are not likely to be triggered by developers so this is a good enough compromise. Branches that are not developed anymore will stay in snyk for now and require manual removal.
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
…#133751) (elastic#133757) we filter by regex for common name pattern of the dev branches to reduce risk of running from development branch. in reality those periodic builds are not likely to be triggered by developers so this is a good enough compromise. Branches that are not developed anymore will stay in snyk for now and require manual removal.
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
…#133751) (elastic#133757) we filter by regex for common name pattern of the dev branches to reduce risk of running from development branch. in reality those periodic builds are not likely to be triggered by developers so this is a good enough compromise. Branches that are not developed anymore will stay in snyk for now and require manual removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Delivery/Build
Build or test infrastructure
>non-issue
Team:Delivery
Meta label for Delivery team
v8.18.7
v8.19.4
v9.0.7
v9.1.4
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we filter by regex for common name pattern of the dev branches to reduce
risk of running from development branch. in reality those periodic builds are
not likely to be triggered by developers so this is a good enough compromise.
Branches that are not developed anymore will stay in snyk for now and require
manual removal.