-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ESQL: Add url_decode function (#133494) #133761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mouhc1ne
commented
Aug 28, 2025
- Add url_decode as a snapshot function.
- Move common logic to both encode/decode to a parent class
🔍 Preview links for changed docs |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/kibana-esql (ES|QL-ui) |
ivancea
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
...src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/convert/UrlDecode.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/xpack/esql/expression/function/scalar/convert/UrlDecodeTests.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/xpack/esql/expression/function/scalar/convert/UrlEncodeTests.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/xpack/esql/expression/function/scalar/convert/UrlDecodeTests.java
Outdated
Show resolved
Hide resolved
...t/java/org/elasticsearch/xpack/esql/expression/function/AbstractUrlEncodeDecodeTestCase.java
Outdated
Show resolved
Hide resolved
4b80e43 to
c3b9ee5
Compare
- Add url_decode as a snapshot function. - Move common logic to both encode/decode to a parent class
ivancea
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
>enhancement
ES|QL-ui
Impacts ES|QL UI
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
test-release
Trigger CI checks against release build
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.