Skip to content

Conditionally generate warnings logic in EvaluatorImplementer. #133765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Conditionally generate warnings logic in EvaluatorImplementer. #133765

wants to merge 2 commits into from

Conversation

@mjmbischoff
Copy link
Contributor

Remove unused warnings field and related logic from NowEvaluator and conditionally generate it in EvaluatorImplementer.

@mjmbischoff
Remove unused warnings field and related logic from NowEvaluator …
2a18b4b 
…and conditionally generate it in `EvaluatorImplementer`.
@elasticsearchmachine
Copy link
Collaborator

@mjmbischoff please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v9.2.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 28, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed needs:triage Requires assignment of a team area label labels Aug 29, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@mjmbischoff mjmbischoff added >non-issue needs:triage Requires assignment of a team area label and removed Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Aug 29, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed needs:triage Requires assignment of a team area label labels Aug 29, 2025
@mjmbischoff mjmbischoff self-assigned this Aug 29, 2025
@mjmbischoff mjmbischoff marked this pull request as draft September 29, 2025 12:13
@mjmbischoff mjmbischoff marked this pull request as ready for review September 29, 2025 12:13
@mjmbischoff mjmbischoff deleted the EvaluatorImplementer-conditional-warnings branch September 29, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mjmbischoff mjmbischoff

Labels

:Analytics/ES|QL AKA ESQL external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjmbischoff @elasticsearchmachine