Migrate the rest of the 9.2 transport versions to the new file system #133769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Transport API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Aug 29, 2025
There was a problem hiding this comment.
I think we should do smaller batches. Specifically, I think we should limit the constants we migrate to the same set of backport branches. This will make the backports simpler (and safer) since the code changes going to .support will always be applicable. Otherwise we need to revert some files changes as we cherry pick to each branch, which seems complicated.
| ALL_VERSIONS_BY_NAME = Collections.unmodifiableMap(allVersionsByName); | ||
|
|
||
| CURRENT = ALL_VERSIONS.getLast(); | ||
| MINIMUM_CCS_VERSION = ALL_VERSIONS_BY_ID.get(9112006); |
There was a problem hiding this comment.
can you add a comment here that this is temporary? we need to move this to a resource file, but we'll need a new concept
There was a problem hiding this comment.
I'll try to separate this specific issue out into a separate pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change migrates any remaining 9.2 transport versions to the new file system.
ES-12334