Fixed LogsIndexModeRollingUpgradeIT

[Kubik42]

This is a follow up for #133493 and #133562.

This resolves #133543.

There a series of problems with this test case, namely:

• it doesn't use a cluster with OLD_CLUSTER_VERSION, meaning the cluster upgrade just upgrades from newest version to newest version
• it doesn't correctly configure the cluster to be used during the upgrade (missing getUpgradeCluster()), meaning we upgrade the base cluster, defined in the parent class, instead of the correct one
• it performs a rollover immediately after upgrading a single nodes and immediately after upgrading all nodes - this makes it impossible to catch issues with the upgraded write index since it gets replaced by a new one

This PR addresses all of these problems + refactors the class to be cleaner and more readable.

Note, even if this test were setup correctly, it would not have caught the norms bwc bug. This is because that bug is triggered on existing logsdb indices during upgrade. In this case however, we only enable logsdb once the upgrade is completed. There is already a test that verifies this, its LogsdbIndexingRollingUpgradeIT.

To verify that the changes in this PR are effective, I enabled logsdb early and reverted my change in #133493. The result is the following error, as expected:

LogsIndexModeRollingUpgradeIT > testLogsIndexing {upgradedNodes=3} FAILED
    java.lang.AssertionError: errors in response:
     {took=205, items=[{create={_index=.ds-logs-apache-production-2025.08.28-000001, failure_store=not_enabled, _id=AZjy4-P3wFxl9GupgoTh, error={reason=cannot change field "message" from omitNorms=false to inconsistent omitNorms=true, type=illegal_argument_exception}, status=400}}, {create={_index=.ds-logs-apache-production-2025.08.28-000001, failure_store=not_enabled, _id=AZjy4-P3wFxl9GupgoTi, error={reason=cannot change field "message" from omitNorms=false to inconsistent omitNorms=true, type=illegal_argument_exception}, status=400}}, {create={_index=.ds-logs-apache-production-2025.08.28-000001, failure_store=not_enabled, _id=AZjy4-P3wFxl9GupgoTj, error={reason=cannot change field "message" from omitNorms=false to inconsistent omitNorms=true, type=illegal_argument_exception}, status=400}}, {create={_index=.ds-logs-apache-production-2025.08.28-000001, failure_store=not_enabled, _id=AZjy4-P3wFxl9GupgoTk, error={reason=cannot change field "message" from omitNorms=false to inconsistent omitNorms=true, type=illegal_argument_exception}, status=400}}, {create={_index=.ds-logs-apache-production-2025.08.28-000001, failure_store=not_enabled, _id=AZjy4-P3wFxl9GupgoTl, error={reason=cannot change field "message" from omitNorms=false to inconsistent omitNorms=true, type=illegal_argument_exception}, status=400}}, {create={_index=.ds-logs-apache-production-2025.08.28-000001, failure_store=not_enabled, _id=AZjy4-P3wFxl9GupgoTm, error={reason=cannot change field "message" from omitNorms=false to inconsistent omitNorms=true, type=illegal_argument_exception}, status=400}}, {create={_index=.ds-logs-apache-production-2025.08.28-000001, failure_store=not_enabled, _id=AZjy4-P3wFxl9GupgoTn, error={reason=cannot change field "message" from omitNorms=false to inconsistent omitNorms=true, type=illegal_argument_exception}, status=400}}, {create={_index=.ds-logs-apache-production-2025.08.28-000001, failure_store=not_enabled, _id=AZjy4-P3wFxl9GupgoTo, error={reason=cannot change field "message" from omitNorms=false to inconsistent omitNorms=true, type=illegal_argument_exception}, status=400}}, {create={_index=.ds-logs-apache-production-2025.08.28-000001, failure_store=not_enabled, _id=AZjy4-P3wFxl9GupgoTp, error={reason=cannot change field "message" from omitNorms=false to inconsistent omitNorms=true, type=illegal_argument_exception}, status=400}}, {create={_index=.ds-logs-apache-production-2025.08.28-000001, failure_store=not_enabled, _id=AZjy4-P3wFxl9GupgoTq, error={reason=cannot change field "message" from omitNorms=false to inconsistent omitNorms=true, type=illegal_argument_exception}, status=400}}, {create={_index=.ds-logs-apache-production-2025.08.28-000001, failure_store=not_enabled, _id=AZjy4-P3wFxl9GupgoTr, error={reason=cannot change field "message" from omitNorms=false to inconsistent omitNorms=true, type=illegal_argument_exception}, status=400}}, {create={_index=.ds-logs-apache-production-2025.08.28-000001, failure_store=not_enabled, _id=AZjy4-P3wFxl9GupgoTs, error={reason=cannot change field "message" from omitNorms=false to inconsistent omitNorms=true, type=illegal_argument_exception}, status=400}}], errors=true}
    Expected: is <false>
         but: was <true>
        at __randomizedtesting.SeedInfo.seed([9AC1444837164B09:A77BFF1C68A802D7]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
        at org.elasticsearch.test.ESTestCase.assertThat(ESTestCase.java:2710)
        at org.elasticsearch.upgrades.LogsIndexModeRollingUpgradeIT.bulkIndex(LogsIndexModeRollingUpgradeIT.java:197)
        at org.elasticsearch.upgrades.LogsIndexModeRollingUpgradeIT.testLogsIndexing(LogsIndexModeRollingUpgradeIT.java:132)

[elasticsearchmachine]

Pinging @elastic/es-storage-engine (Team:StorageEngine)

[Kubik42]

since we no longer rollover when the cluster is in a mixed state, we have only two indices at the end

[Kubik42]

printing the error in response here makes finding the errors significantly easier. Previously, I had to log dive to understand what happened

[Kubik42]

Swapped AbstractRollingUpgradeTestCase for AbstractRollingUpgradeWithSecurityTestCase since this test has auth enabled.

[martijnvg]

LGTM 👍