Skip to content

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Aug 29, 2025

We should increment the timestamp for all documents; otherwise, the last two documents may share the same timestamp, resulting in an undefined order between them.

Closes #133766

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :StorageEngine/Codec labels Aug 29, 2025
@dnhatn dnhatn requested review from kkrik-es and martijnvg August 29, 2025 06:43
@dnhatn dnhatn marked this pull request as ready for review August 29, 2025 06:43
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dnhatn dnhatn enabled auto-merge (squash) August 29, 2025 06:49
@dnhatn dnhatn merged commit 8672dba into elastic:main Aug 29, 2025
33 checks passed
@dnhatn dnhatn deleted the testOptionalColumnAtATimeReaderWithSparseDocs branch August 29, 2025 07:43
JeremyDahlgren pushed a commit to JeremyDahlgren/elasticsearch that referenced this pull request Aug 29, 2025
We should increment the timestamp for all documents; otherwise, the last 
two documents may share the same timestamp, resulting in an undefined
order between them.

Closes elastic#133766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:StorageEngine/Codec Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] ES819TSDBDocValuesFormatTests testOptionalColumnAtATimeReaderWithSparseDocs failing

4 participants