Skip to content

ESQL: refine again the inlinestats unit test for release version #133785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

ESQL: refine again the inlinestats unit test for release version #133785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 34 additions & 34 deletions ...lasticsearch/xpack/esql/optimizer/rules/logical/ReplaceStatsFilteredAggWithEvalTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,8 @@ public void testReplaceStatsFilteredAggWithEvalSingleAggWithGroup() {
*/
public void testReplaceInlinestatsFilteredAggWithEvalSingleAgg() {
var query = """
from test
| inlinestats sum(salary) where false
FROM test
| INLINESTATS sum(salary) where false
""";
if (releaseBuildForInlinestats(query)) {
return;
Expand Down Expand Up @@ -436,8 +436,8 @@ public void testReplaceInlinestatsFilteredAggWithEvalSingleAgg() {
*/
public void testReplaceInlinestatsFilteredAggWithEvalSingleAggWithExpression() {
var query = """
from test
| inlinestats sum(salary) + 1 where false
FROM test
| INLINESTATS sum(salary) + 1 where false
""";
if (releaseBuildForInlinestats(query)) {
return;
Expand Down Expand Up @@ -483,11 +483,11 @@ public void testReplaceInlinestatsFilteredAggWithEvalSingleAggWithExpression() {
*/
public void testReplaceInlinestatsFilteredAggWithEvalMixedFilterAndNoFilter() {
var query = """
from test
| keep salary, emp_no
| inlinestats sum(salary) + 1 where false,
FROM test
| KEEP salary, emp_no
| INLINESTATS sum(salary) + 1 where false,
sum(salary) + 2
by emp_no
BY emp_no
""";
if (releaseBuildForInlinestats(query)) {
return;
Expand Down Expand Up @@ -539,9 +539,9 @@ public void testReplaceInlinestatsFilteredAggWithEvalMixedFilterAndNoFilter() {
*/
public void testReplaceInlinestatsFilteredAggWithEvalFilterFalseAndNull() {
var query = """
from test
| keep salary
| inlinestats sum(salary) + 1 where false,
FROM test
| KEEP salary
| INLINESTATS sum(salary) + 1 where false,
sum(salary) + 3,
sum(salary) + 2 where null,
sum(salary) + 4 where not true
Expand Down Expand Up @@ -593,9 +593,9 @@ public void testReplaceInlinestatsFilteredAggWithEvalFilterFalseAndNull() {
*/
public void testReplaceInlinestatsFilteredAggWithEvalNotTrue() {
var query = """
from test
| keep emp_no, salary
| inlinestats count(salary) where not true
FROM test
| KEEP emp_no, salary
| INLINESTATS count(salary) where not true
""";
if (releaseBuildForInlinestats(query)) {
return;
Expand Down Expand Up @@ -626,9 +626,9 @@ public void testReplaceInlinestatsFilteredAggWithEvalNotTrue() {
*/
public void testReplaceInlinestatsFilteredAggWithEvalNotFalse() {
var query = """
from test
| keep emp_no, salary, gender
| inlinestats m1 = count(salary) where not false
FROM test
| KEEP emp_no, salary, gender
| INLINESTATS m1 = count(salary) WHERE not false
""";
if (releaseBuildForInlinestats(query)) {
return;
Expand Down Expand Up @@ -660,9 +660,9 @@ public void testReplaceInlinestatsFilteredAggWithEvalNotFalse() {
*/
public void testReplaceInlinestatsFilteredAggWithEvalCount() {
var query = """
from test
| keep salary
| inlinestats count(salary) where false
FROM test
| KEEP salary
| INLINESTATS count(salary) where false
""";
if (releaseBuildForInlinestats(query)) {
return;
Expand Down Expand Up @@ -690,9 +690,9 @@ public void testReplaceInlinestatsFilteredAggWithEvalCount() {
*/
public void testReplaceInlinestatsFilteredAggWithEvalCountDistinctInExpression() {
var query = """
from test
| keep salary
| inlinestats count_distinct(salary + 2) + 3 where false
FROM test
| KEEP salary
| INLINESTATS count_distinct(salary + 2) + 3 where false
""";
if (releaseBuildForInlinestats(query)) {
return;
Expand Down Expand Up @@ -725,12 +725,12 @@ public void testReplaceInlinestatsFilteredAggWithEvalCountDistinctInExpression()
*/
public void testReplaceInlinestatsFilteredAggWithEvalSameAggWithAndWithoutFilter() {
var query = """
from test
| keep emp_no, salary
| inlinestats max = max(salary), max_a = max(salary) where null,
FROM test
| KEEP emp_no, salary
| INLINESTATS max = max(salary), max_a = max(salary) WHERE null,
min = min(salary),
min_a = min(salary) where to_string(null) == "abc"
by emp_no
min_a = min(salary) WHERE to_string(null) == "abc"
BY emp_no
""";
if (releaseBuildForInlinestats(query)) {
return;
Expand Down Expand Up @@ -777,12 +777,12 @@ public void testReplaceInlinestatsFilteredAggWithEvalSameAggWithAndWithoutFilter
*/
public void testReplaceTwoConsecutiveInlinestats_WithFalseFilters() {
var query = """
from test
| keep emp_no
| sort emp_no
| limit 3
| inlinestats count = count(*) where false
| inlinestats cc = count_distinct(emp_no) where false
FROM test
| KEEP emp_no
| SORT emp_no
| LIMIT 3
| INLINESTATS count = count(*) WHERE false
| INLINESTATS cc = count_distinct(emp_no) WHERE false
""";
if (releaseBuildForInlinestats(query)) {
return;
Expand Down