Skip to content

[Sentinel One] - Fix Cannot execute ILM policy delete step #133793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 4, 2025
Merged

[Sentinel One] - Fix Cannot execute ILM policy delete step #133793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f3a5583
Add required ilm index for delete privilege
mohitjha-elastic Aug 29, 2025
e04c727
Add changelog
mohitjha-elastic Aug 29, 2025
061cb93
[CI] Auto commit changes from spotless
Aug 29, 2025
7c3696f
Merge branch 'main' of github.com:mohitjha-elastic/elasticsearch into…
mohitjha-elastic Sep 2, 2025
1a26fb3
Merge branch 'enhancement/sentinel_one-add_ilm_delete_index' of githu…
mohitjha-elastic Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changelog/133793.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
pr: 133793
summary: "[Sentinel One] Add `manage`, `create_index`, `read`, `index`, `write`, `delete`, permission for third party agent indices `kibana_system`"
area: Authorization
type: enhancement
issues:
- 133703
8 changes: 5 additions & 3 deletions ...org/elasticsearch/xpack/core/security/authz/store/KibanaOwnedReservedRoleDescriptors.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,8 @@ static RoleDescriptor kibanaSystem(String name) {
.indices(
"logs-m365_defender.vulnerability-*",
"logs-microsoft_defender_endpoint.vulnerability-*",
"logs-microsoft_defender_cloud.assessment-*"
"logs-microsoft_defender_cloud.assessment-*",
"logs-sentinel_one.application_risk-*"
)
.privileges(
"read",
Expand All @@ -548,10 +549,11 @@ static RoleDescriptor kibanaSystem(String name) {
TransportDeleteIndexAction.TYPE.name()
)
.build(),
// For ExtraHop and QualysGAV specific actions. Kibana reads, writes and manages this index
// For ExtraHop, QualysGAV, and SentinelOne Application Dataset specific actions. Kibana reads, writes and manages this
// index
// for configured ILM policies.
RoleDescriptor.IndicesPrivileges.builder()
.indices("logs-extrahop.investigation-*", "logs-qualys_gav.asset-*")
.indices("logs-extrahop.investigation-*", "logs-qualys_gav.asset-*", "logs-sentinel_one.application-*")
.privileges(
"manage",
"create_index",
Expand Down
8 changes: 5 additions & 3 deletions .../test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1773,7 +1773,8 @@ public void testKibanaSystemRole() {
Arrays.asList(
"logs-m365_defender.vulnerability-" + randomAlphaOfLength(randomIntBetween(0, 13)),
"logs-microsoft_defender_endpoint.vulnerability-" + randomAlphaOfLength(randomIntBetween(0, 13)),
"logs-microsoft_defender_cloud.assessment-" + randomAlphaOfLength(randomIntBetween(0, 13))
"logs-microsoft_defender_cloud.assessment-" + randomAlphaOfLength(randomIntBetween(0, 13)),
"logs-sentinel_one.application_risk-" + randomAlphaOfLength(randomIntBetween(0, 13))
).forEach(indexName -> {
final IndexAbstraction indexAbstraction = mockIndexAbstraction(indexName);
assertThat(kibanaRole.indices().allowedIndicesMatcher("indices:foo").test(indexAbstraction), is(false));
Expand Down Expand Up @@ -1975,11 +1976,12 @@ public void testKibanaSystemRole() {
assertThat(kibanaRole.indices().allowedIndicesMatcher(RolloverAction.NAME).test(indexAbstraction), is(true));
});

// Tests for third-party agent indices (ExtraHop, QualysGAV) that `kibana_system` has full management access to
// Tests for third-party agent indices (ExtraHop, QualysGAV, SentinelOne) that `kibana_system` has full management access to
// This includes read, write, create, delete, and all ILM-related management actions.
Arrays.asList(
"logs-extrahop.investigation-" + randomAlphaOfLength(randomIntBetween(1, 10)),
"logs-qualys_gav.asset-" + randomAlphaOfLength(randomIntBetween(1, 10))
"logs-qualys_gav.asset-" + randomAlphaOfLength(randomIntBetween(1, 10)),
"logs-sentinel_one.application-" + randomAlphaOfLength(randomIntBetween(1, 10))
).forEach((index_qualys_extra_hop) -> {
final IndexAbstraction indexAbstraction = mockIndexAbstraction(index_qualys_extra_hop);

Expand Down