[Gradle] Fix test seed handling when running with cc #133811

breskeby · 2025-08-29T12:39:10Z

This ensures we provide a new test seed per build invocation when running
with configuration cache enabled while still ensuring the configuration cache
can be reused.

basically test seed beeing ignored as cc input.

elasticsearchmachine · 2025-08-29T12:39:35Z

Pinging @elastic/es-delivery (Team:Delivery)

breskeby · 2025-08-29T12:42:12Z

x-pack/qa/multi-cluster-search-security/legacy-with-full-license/build.gradle

 }

 // randomise between sniff and proxy modes
-boolean proxyMode = buildParams.random.nextBoolean()


this resolves test seed early basically breaking configuration cache reusability every time

breskeby · 2025-08-29T12:44:54Z

...ols-internal/src/main/java/org/elasticsearch/gradle/internal/info/GlobalBuildInfoPlugin.java

-            testSeed = testSeedProperty;
-        }
-        return testSeed;
+    private Provider<String> getTestSeed() {


In order to be able to pass a changing value to Test tasks without breaking configuration cache reuse, we have to rely on a ValueSource here that we pass down all the way to "noninputproperties" CommandLineProvider we configure for tests tasks. ValueSource allows being opaque to the configuration cache. Other providers or plain string would always be interpreted as inputs to the configuration cache, resulting in the test seed not changing between multiple build invocation without configuration cache change

breskeby · 2025-08-29T12:45:48Z

x-pack/qa/multi-cluster-search-security/legacy-with-basic-license/build.gradle

 }

 // randomise between sniff and proxy modes
-boolean proxyMode = buildParams.random.nextBoolean()


since we only use this in deprecated TestCluster settings I did not invest to much time to sugar code that api here for now. Ultimately this moves into tests at one point 🤞

This ensures we provide a new test seed per build invocation when running with configuration cache enabled while still ensuring the configuration cache can be reused. basically test seed beeing ignored as cc input.

breskeby · 2025-09-04T08:44:45Z

x-pack/plugin/security/qa/profile/build.gradle

  javaRestTestImplementation project(':x-pack:plugin:security')
 }

-boolean literalUsername = buildParams.random.nextBoolean()


buildParams.random resolves the TestSeed and breaks configuration-cache. by moving this into the task configuration block we defer that. for this particular test cc will always be out of date. Longterm we might wand a more deterministic way of testing this behaviour

The altenative would be to split the random from the testseed,, but this would break reproducability.

breskeby · 2025-09-04T08:46:50Z

...ols-internal/src/main/java/org/elasticsearch/gradle/internal/info/GlobalBuildInfoPlugin.java

        this.javaInstallationRegistry = javaInstallationRegistry;
        this.metadataDetector = new ErrorTraceMetadataDetector(metadataDetector);
        this.providers = providers;
-        this.branchesFileParser = new BranchesFileParser(new ObjectMapper());


this seems only used at one point. therefore I removed the field property.

Good point. I got the impression that it belongs in constructor, to avoid creating it on every method call, but the apply method will be called only once anyway.

breskeby · 2025-09-04T08:47:56Z

...ols-internal/src/main/java/org/elasticsearch/gradle/internal/info/GlobalBuildInfoPlugin.java

        this.project = project;
        project.getPlugins().apply(JvmToolchainsPlugin.class);
        project.getPlugins().apply(JdkDownloadPlugin.class);
+        project.getPlugins().apply(VersionPropertiesPlugin.class);


I tend to follow the pattern of applying nested plugins as early as possible (there are edge cases where you might only do it on certain conditions) in the apply method. that makes reading way simpler and I think its common practice

breskeby · 2025-09-04T08:48:40Z

...ols-internal/src/main/java/org/elasticsearch/gradle/internal/info/GlobalBuildInfoPlugin.java

+
+        if (buildFeatures.getConfigurationCache().getActive().get() == false) {
+            // if configuration cache is enabled, resolving the test seed early breaks configuration cache reuse
+            LOGGER.quiet("  Random Testing Seed   : " + buildParams.getTestSeed());


the test seed printing resolves the ValueSource early and breaks configuration cache. therefore only print if not running in cc

breskeby · 2025-09-04T08:50:50Z

...tools-internal/src/main/java/org/elasticsearch/gradle/internal/info/TestSeedValueSource.java

+import java.util.Locale;
+import java.util.Random;
+
+public abstract class TestSeedValueSource implements ValueSource<String, ValueSourceParameters.None> {


We need to model the TestSeed resolution as ValueSource as this allows passing the parameter transparently for the configuration cache down to the consumers (test cases, testcluster).

Taking this from the according javadoc:

Represents an external source of information used by a Gradle build. Examples of external sources include client environment variables, system properties, configuration files, shell commands, network services, among others. Representing external sources as [ValueSource](https://docs.gradle.org/current/javadoc/org/gradle/api/provider/ValueSource.html)s allows Gradle to transparently manage [the configuration cache](https://docs.gradle.org/current/userguide/configuration_cache.html) as values obtained from those sources change. For example, a build might run a different set of tasks depending on whether the CI environment variable is set or not.

This ensures we provide a new test seed per build invocation when running with configuration cache enabled while still ensuring the configuration cache can be reused. basically test seed beeing ignored as cc input.

elasticsearchmachine · 2025-09-04T14:16:01Z

💔 Backport failed

Status	Branch	Result
✅	9.1
❌	9.0	Commit could not be cherrypicked due to conflicts
❌	8.18	Commit could not be cherrypicked due to conflicts
❌	8.19	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 133811

This ensures we provide a new test seed per build invocation when running with configuration cache enabled while still ensuring the configuration cache can be reused. basically test seed beeing ignored as cc input. (cherry picked from commit 8097c1a) # Conflicts: # x-pack/plugin/security/qa/profile/build.gradle

breskeby · 2025-09-04T15:10:09Z

💔 Some backports could not be created

Status	Branch	Result
✅	9.0
✅	8.19
❌	8.18	Could not create pull request: fetch failed

Manual backport

To create the backport manually run:

backport --pr 133811

Questions ?

Please refer to the Backport tool documentation

This ensures we provide a new test seed per build invocation when running with configuration cache enabled while still ensuring the configuration cache can be reused. basically test seed beeing ignored as cc input. (cherry picked from commit 8097c1a) # Conflicts: # x-pack/plugin/security/qa/profile/build.gradle

breskeby · 2025-09-04T15:12:18Z

💚 All backports created successfully

Status	Branch	Result
✅	8.18

Questions ?

Please refer to the Backport tool documentation

This ensures we provide a new test seed per build invocation when running with configuration cache enabled while still ensuring the configuration cache can be reused. basically test seed beeing ignored as cc input.

This ensures we provide a new test seed per build invocation when running with configuration cache enabled while still ensuring the configuration cache can be reused. basically test seed beeing ignored as cc input. (cherry picked from commit 8097c1a) # Conflicts: # x-pack/plugin/security/qa/profile/build.gradle

…#134149) * [Gradle] Fix test seed handling when running with cc (#133811) This ensures we provide a new test seed per build invocation when running with configuration cache enabled while still ensuring the configuration cache can be reused. basically test seed beeing ignored as cc input. (cherry picked from commit 8097c1a) # Conflicts: # x-pack/plugin/security/qa/profile/build.gradle * Fix merge issue

BASE=24bd70b9d1eb60747a7ba3b7c971e2096da843fd HEAD=a25ede51f680602cdeeae9b45d1540ca9fbcc04f Branch=main

…elastic#134147) This ensures we provide a new test seed per build invocation when running with configuration cache enabled while still ensuring the configuration cache can be reused. basically test seed beeing ignored as cc input. (cherry picked from commit 8097c1a) # Conflicts: # x-pack/plugin/security/qa/profile/build.gradle

BASE=24bd70b9d1eb60747a7ba3b7c971e2096da843fd HEAD=a25ede51f680602cdeeae9b45d1540ca9fbcc04f Branch=main

…elastic#134147) This ensures we provide a new test seed per build invocation when running with configuration cache enabled while still ensuring the configuration cache can be reused. basically test seed beeing ignored as cc input. (cherry picked from commit 8097c1a) # Conflicts: # x-pack/plugin/security/qa/profile/build.gradle

BASE=24bd70b9d1eb60747a7ba3b7c971e2096da843fd HEAD=a25ede51f680602cdeeae9b45d1540ca9fbcc04f Branch=main

breskeby added >non-issue :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team labels Aug 29, 2025

breskeby requested a review from a team as a code owner August 29, 2025 12:39

breskeby added auto-backport Automatically create backport pull requests when merged v9.2.0 v9.1.4 v9.0.7 v8.18.7 v8.19.4 labels Aug 29, 2025

breskeby self-assigned this Aug 29, 2025

breskeby changed the title ~~Fix testseed handling when running with cc~~ Fix test seed handling when running with cc Aug 29, 2025

breskeby commented Aug 29, 2025

View reviewed changes

breskeby changed the title ~~Fix test seed handling when running with cc~~ [Gradle] Fix test seed handling when running with cc Aug 29, 2025

breskeby force-pushed the fix-testseed-cc branch from 775cc35 to 6a9f399 Compare August 29, 2025 13:31

elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Aug 29, 2025

breskeby added 4 commits September 4, 2025 09:22

Fix testseed handling when running with cc

381cd97

[Gradle] Test seed should change per invocation and not break CC

87d1aa8

This ensures we provide a new test seed per build invocation when running with configuration cache enabled while still ensuring the configuration cache can be reused. basically test seed beeing ignored as cc input.

Fix more early resolutions of test seed

d9f6c78

Cleanup

769fbb3

breskeby force-pushed the fix-testseed-cc branch from 6a9f399 to 769fbb3 Compare September 4, 2025 07:48

Simplify test

4a9f74a

breskeby commented Sep 4, 2025

View reviewed changes

breskeby added 2 commits September 4, 2025 13:42

Merge branch 'main' into fix-testseed-cc

c9ff966

Merge branch 'main' into fix-testseed-cc

a25ede5

breskeby merged commit 8097c1a into elastic:main Sep 4, 2025
33 checks passed

breskeby mentioned this pull request Sep 4, 2025

[9.1] [Gradle] Fix test seed handling when running with cc (#133811) #134139

Merged

elasticsearchmachine added the backport pending label Sep 4, 2025

This was referenced Sep 4, 2025

[9.0] [Gradle] Fix test seed handling when running with cc (#133811) #134146

Merged

[8.19] [Gradle] Fix test seed handling when running with cc (#133811) #134147

Merged

breskeby mentioned this pull request Sep 4, 2025

[8.18] [Gradle] Fix test seed handling when running with cc (#133811) #134149

Merged

phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 11, 2025

Mirror upstream elastic#133811 as single snapshot commit for AI review

28d0a46

BASE=24bd70b9d1eb60747a7ba3b7c971e2096da843fd HEAD=a25ede51f680602cdeeae9b45d1540ca9fbcc04f Branch=main

phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 11, 2025

Mirror upstream elastic#133811 as single snapshot commit for AI review

ca5a05f

BASE=24bd70b9d1eb60747a7ba3b7c971e2096da843fd HEAD=a25ede51f680602cdeeae9b45d1540ca9fbcc04f Branch=main

phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 16, 2025

Mirror upstream elastic#133811 as single snapshot commit for AI review

4726290

BASE=24bd70b9d1eb60747a7ba3b7c971e2096da843fd HEAD=a25ede51f680602cdeeae9b45d1540ca9fbcc04f Branch=main

phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 16, 2025

Mirror upstream elastic#133811 as single snapshot commit for AI review

b56f108

BASE=24bd70b9d1eb60747a7ba3b7c971e2096da843fd HEAD=a25ede51f680602cdeeae9b45d1540ca9fbcc04f Branch=main

phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 16, 2025

Mirror upstream elastic#133811 as single snapshot commit for AI review

3fea59f

BASE=24bd70b9d1eb60747a7ba3b7c971e2096da843fd HEAD=a25ede51f680602cdeeae9b45d1540ca9fbcc04f Branch=main

phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 8, 2025

Mirror upstream elastic#133811 as single snapshot commit for AI review

ff535f5

BASE=24bd70b9d1eb60747a7ba3b7c971e2096da843fd HEAD=a25ede51f680602cdeeae9b45d1540ca9fbcc04f Branch=main

coderabbitai bot mentioned this pull request Oct 9, 2025

Mirror upstream elastic/elasticsearch#133811 for AI review (snapshot of HEAD tree) phananh1010/elasticsearch#143

Closed

[Gradle] Fix test seed handling when running with cc #133811

[Gradle] Fix test seed handling when running with cc #133811

Uh oh!

Conversation

breskeby commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticsearchmachine commented Aug 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

breskeby Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticsearchmachine commented Sep 4, 2025

💔 Backport failed

Uh oh!

breskeby commented Sep 4, 2025

💔 Some backports could not be created

Manual backport

Questions ?

Uh oh!

breskeby commented Sep 4, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

breskeby commented Aug 29, 2025 •

edited

Loading

breskeby Sep 4, 2025 •

edited

Loading