-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Mark user profile APIs as public #133819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark user profile APIs as public #133819
Conversation
They are used in Kibana, and documented as Kibana-only in the documentation.
Pinging @elastic/es-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this @pquentin! In Serverless, these are inaccessible to users directly -- these APIs can only be called by operator users. Do we have a visibility
value that captures this distinction?
Serverless availability is encoded in the Elasticsearch specification: https://github.com/elastic/elasticsearch-specification/blob/424b5471c7acdc4e4f088ed186fe7ce97db23c2b/specification/security/activate_user_profile/Request.ts#L40. rest-api-spec is only about the stack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
They are used in Kibana, and documented as Kibana-only in the documentation.
They are used in Kibana, and documented as Kibana-only in the documentation.
They are used in Kibana, and documented as Kibana-only in the documentation.
They are used in Kibana, and documented as Kibana-only in the documentation.
They are used in Kibana, and documented as Kibana-only in the documentation.
They are used in Kibana through the JS client, and documented as Kibana-only in the docs, so the correct marker is in fact "public".
I'm planning to generate the rest-api-spec from the Elasticsearch specification, but I need to eliminate the differences first.