Skip to content

Fix missing position offset in lossy sum of doubles #133833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

Fix missing position offset in lossy sum of doubles #133833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,15 +543,6 @@ tests:
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT
method: test
issue: https://github.com/elastic/elasticsearch/issues/133077
- class: org.elasticsearch.compute.aggregation.LossySumDoubleGroupingAggregatorFunctionTests
method: testManyInitialManyPartialFinalRunner
issue: https://github.com/elastic/elasticsearch/issues/133809
- class: org.elasticsearch.compute.aggregation.LossySumDoubleGroupingAggregatorFunctionTests
method: testInitialIntermediateFinal
issue: https://github.com/elastic/elasticsearch/issues/133822
- class: org.elasticsearch.compute.aggregation.LossySumDoubleGroupingAggregatorFunctionTests
method: testInitialFinal
issue: https://github.com/elastic/elasticsearch/issues/133829
- class: org.elasticsearch.xpack.esql.action.RandomizedTimeSeriesIT
method: testGroupBySubset
issue: https://github.com/elastic/elasticsearch/issues/133220
Expand Down
4 changes: 2 additions & 2 deletions ...compute/src/main/java/org/elasticsearch/compute/aggregation/LossySumDoubleAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ public void add(int positionOffset, IntBigArrayBlock groupIds) {
public void add(int positionOffset, IntVector groupIds) {
if (groupIds.isConstant()) {
double sum = 0.0;
int positionCount = groupIds.getPositionCount();
for (int i = 0; i < positionCount; i++) {
final int to = positionOffset + groupIds.getPositionCount();
for (int i = positionOffset; i < to; i++) {
sum += values.getDouble(i);
}
state.add(sum, groupIds.getInt(0));
Expand Down