ESQL: Simply reenable a disabled test #133838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT test
{csv-spec:inlinestats.EvalBeforeDoubleInlinestats1} got run on version
preceding the one it was introduced in. The failure only occured if the
planning of a query happened on an older version, not containing the fix
the test was testing against. This is why the tests passed. An inline
version capability bump should have been introduced along the fix.
Meanwhile the inlinestats capability version got bumped, so this
situation can no longer occur.
bpintea
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Thanks, Andrei! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT test {csv-spec:inlinestats.EvalBeforeDoubleInlinestats1}got run on version preceding the one it was introduced in. The failure only occured if the planning of a query happened on an older version (2e8507f), not containing the fix (2f0010c) the test was testing against. This is why the tests passed. An inlinestats version capability bump should have been introduced along the fix.Meanwhile the inlinestats capability version got bumped, so this situation can no longer occur.
Fixes #133729