Refactor transport version constants into new file system #133849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
🔍 Preview links for changed docs |
rjernst
approved these changes
Aug 29, 2025
| @@ -0,0 +1 @@ | |||
| 0 | |||
There was a problem hiding this comment.
This will never change, could we have this defined in code as it was before? There's no reason to have it in a resource file.
There was a problem hiding this comment.
I considered both ways but don't have a strong preference so I will switch this back.
jdconrad
added
the
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Aug 29, 2025
…3849) This refactors ZERO, MINIMUM_COMPATIBLE, and MINIMUM_CCS_VERSION into TransportVersion.VersionsHolder and load them from /transport/constants/....
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Aug 29, 2025
…3849) This refactors ZERO, MINIMUM_COMPATIBLE, and MINIMUM_CCS_VERSION into TransportVersion.VersionsHolder and load them from /transport/constants/....
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Aug 29, 2025
…3849) This refactors ZERO, MINIMUM_COMPATIBLE, and MINIMUM_CCS_VERSION into TransportVersion.VersionsHolder and load them from /transport/constants/....
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Aug 29, 2025
…3849) This refactors ZERO, MINIMUM_COMPATIBLE, and MINIMUM_CCS_VERSION into TransportVersion.VersionsHolder and load them from /transport/constants/....
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Aug 29, 2025
…3849) This refactors ZERO, MINIMUM_COMPATIBLE, and MINIMUM_CCS_VERSION into TransportVersion.VersionsHolder and load them from /transport/constants/....
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 2, 2025
…3849) This refactors ZERO, MINIMUM_COMPATIBLE, and MINIMUM_CCS_VERSION into TransportVersion.VersionsHolder and load them from /transport/constants/....
This was referenced Sep 2, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 2, 2025
jdconrad
added a commit
that referenced
this pull request
Sep 2, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
ZERO,MINIMUM_COMPATIBLE, andMINIMUM_CCS_VERSIONintoTransportVersion.VersionsHolderand load them from/transport/constants/....ES-12334