Skip to content

Conversation

pabloem
Copy link
Contributor

@pabloem pabloem commented Aug 30, 2025

A test case that randomly selects which aggregation to conduct against which subset of labels. It supports empty subset (i.e. single aggregation output per window), and any pair of aggregations X(Y_over_time(...)). The test case also randomly selects window size.

This also upgrades the rate test to allow for empty grouping set of columns, random window size and includes all current possible aggregations for the rate function (min,max,avg,sum,count).

@pabloem pabloem marked this pull request as ready for review September 2, 2025 17:51
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Sep 2, 2025
@pabloem pabloem added >test Issues or PRs that are addressing/adding tests :StorageEngine/TSDB You know, for Metrics Team:StorageEngine and removed needs:triage Requires assignment of a team area label labels Sep 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pabloem!

Copy link
Contributor

@kkrik-es kkrik-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@pabloem pabloem enabled auto-merge (squash) September 3, 2025 20:06
@pabloem pabloem merged commit a441617 into elastic:main Sep 3, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants