-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Fix Typo "using using" in RLIKE/LIKE docs #133892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-analytical-engine (Team:Analytics) |
This is almost the right place. We generate these docs by running our tests. So running the tests will undo this. If you do this:
Then run:
That'll regenerate all those md and json files we pass around. It needs to run the tests, but should be fine. A lot of the docs generation stuff is linked into the tests because we generate tables and stuff from the test inputs. Would you like to make those changes on this PR? I'd be happy to merge it. |
The story is that both kibana and the docs build need stuff about esql function. And the place with the most comprehensive list of supported parameter combinations is our docs. So we had the tests generate the json and markdown files kibana and the docs need. It's a bit of a pain to rerun the tests but it's a lot less painful than hand maintaining a bunch of files. We commit the generated markdown and json files because the docs build and kibana build don't know anything about how to run Elaticsearch's build. It's certainly not ideal that these can get out of date. But it's the compromise we chose to keep the docs and kibana builds simpler. |
Please go ahead and resolve as you see fit. I appreciate the back end info as I may give another run at this another time. If this is in the contributor docs somewhere and I missed it, please send me a link! If not, no worries I will use these methods next time. |
Pinging @elastic/core-docs (Team:Docs) |
Looks like I was wrong. This bit isn't generated. But other bits are. I'll catch the other bits up in a follow up change and merge this. |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
`using using` isn't right. Relates to elastic#133892
I opened #134138 to cover the other bits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @nicpenning and @nik9000!
Thanks again @nicpenning . |
`using using` isn't right. Relates to #133892
No problem! Happy to help (or try to :)). |
`using using` isn't right. Relates to elastic#133892
Might fix #133891 ?