Refactor enrich policy resolution #133928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>non-issue
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
commented
Sep 1, 2025
|
|
||
| PreAnalyzer.PreAnalysis preAnalysis = preAnalyzer.preAnalyze(parsed); | ||
| var unresolvedPolicies = preAnalysis.enriches.stream().map(EnrichPolicyResolver.UnresolvedPolicy::from).collect(toSet()); | ||
|
|
There was a problem hiding this comment.
No need to eagerly transform Enrich -> UnresolvedPolicy here.
This is going to be transformed later in enrichPolicyResolver but only if there are actual policies to resolve.
idegtiarenko
commented
Sep 1, 2025
| } | ||
|
|
||
| doResolvePolicies( | ||
| new HashSet<>(executionInfo.getClusters().keySet()), |
There was a problem hiding this comment.
This separates enrich resolution from resolving list of remotes.
Today this is simply taken from the parsed list of expressions.
In future this is going to be replaced with async index resolution step, remotes taken from its result and supplied to doResolvePolicies via listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements trivial refactorings before moving enrich resolutions to its own field caps call.